From owner-freebsd-current@FreeBSD.ORG Mon May 30 06:15:27 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A49F16A41C for ; Mon, 30 May 2005 06:15:27 +0000 (GMT) (envelope-from jiashiun@gmail.com) Received: from rproxy.gmail.com (rproxy.gmail.com [64.233.170.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC03A43D1D for ; Mon, 30 May 2005 06:15:26 +0000 (GMT) (envelope-from jiashiun@gmail.com) Received: by rproxy.gmail.com with SMTP id a41so1324165rng for ; Sun, 29 May 2005 23:15:26 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=D+nVBO3/eM4Hp6fvxlQmX4rks1NRmw0e8JS/m4pamJl5dP5/qezLRpsSr3WAeA1bc86N3LbkYRCft0vnPxVZmvdAtpi/TijDN4ufNZDrWwQeLUpCPjexjthV4nN5V7HJmpz3tYiV9werp8/kFWYZKv2UXqKYM2VYZtJohTQmwmQ= Received: by 10.38.161.27 with SMTP id j27mr5819066rne; Sun, 29 May 2005 23:15:26 -0700 (PDT) Received: by 10.38.12.29 with HTTP; Sun, 29 May 2005 23:15:26 -0700 (PDT) Message-ID: <1d6d20bc050529231530700157@mail.gmail.com> Date: Mon, 30 May 2005 14:15:26 +0800 From: Jia-Shiun Li To: freebsd-current@freebsd.org, =?ISO-8859-1?Q?S=F8ren_Schmidt?= , Ian Dowse In-Reply-To: <1d6d20bc05031408071558b6ce@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <1d6d20bc0503100101621bbee3@mail.gmail.com> <1d6d20bc05031408071558b6ce@mail.gmail.com> Cc: Subject: Re: VESA non-VGA flag X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jia-Shiun Li List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2005 06:15:27 -0000 Ok I filed PR i386/81445. Next could somebody tell me how to get it commited, or am I missing anything else? Jia-Shiun. On 3/15/05, Jia-Shiun Li wrote: > On Thu, 10 Mar 2005 17:01:13 +0800, Jia-Shiun Li wro= te: > > Hi, > > > > These days I was trying to add a splash screen. I used VMWare to test, > > but it cannot init VESA correctly, which is odd since VMWare claimed > > its display to be VESA compliant. I then traced into > > src/sys/i386/isa/vesa.c, found that it was cause by the flag V_NONVGA. > > It will stop initializing if this flag is set, at line 655(v1.50). If > > I comment it out, VESA will work on VMWare and I can happily use my > > splash screen during booting. > > > > I tried to google some info, but still cannot figure out if the > > 'non-VGA' flag really means 'not (IBM)VGA backward-compatible' or 'not > > a display device at all'. But since anything implementing VBE must be > > a display device to make sense, I suppose it to be the former. The > > question is, if the checking of non-VGA flag can be safely removed? I > > do not know if there is any devices depending on it to work correctly. > > To me it seems ok without the checking. > > >=20 > According to VBE 3.0 page 26, the non-vga flag means 'not VGA > compatible', so it should not prevent VESA from initializing. >=20 > I did not found anyone responsible for this. S=F8ren and Ian could you > take a look at this patch? It makes VESA work on VMWare without > breaking it on other (real)hardwares. >=20 > Jia-Shiun. >=20 > --- sys/i386/isa/vesa.c.orig Mon Mar 14 23:55:19 2005 > +++ sys/i386/isa/vesa.c Mon Mar 14 23:55:42 2005 > @@ -652,8 +652,6 @@ > printf("VESA: information block\n"); > dump_buffer(buf, 64); > } > - if (vesa_adp_info->v_flags & V_NONVGA) > - return 1; > if (vesa_adp_info->v_version < 0x0102) { > printf("VESA: VBE version %d.%d is not supported; " > "version 1.2 or later is required.\n", >=20 >=20 >