From owner-svn-src-all@FreeBSD.ORG Mon Oct 26 15:45:18 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 412F3106568F; Mon, 26 Oct 2009 15:45:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 12C4D8FC0A; Mon, 26 Oct 2009 15:45:18 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id B934046B0D; Mon, 26 Oct 2009 11:45:17 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id EDCD58A01F; Mon, 26 Oct 2009 11:45:16 -0400 (EDT) From: John Baldwin To: Marcel Moolenaar Date: Mon, 26 Oct 2009 08:37:23 -0400 User-Agent: KMail/1.9.7 References: <200910232253.n9NMr10R074584@svn.freebsd.org> In-Reply-To: <200910232253.n9NMr10R074584@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910260837.23479.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 26 Oct 2009 11:45:17 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00, DATE_IN_PAST_03_06,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r198431 - head/sys/dev/pci X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2009 15:45:18 -0000 On Friday 23 October 2009 6:53:01 pm Marcel Moolenaar wrote: > Author: marcel > Date: Fri Oct 23 22:53:01 2009 > New Revision: 198431 > URL: http://svn.freebsd.org/changeset/base/198431 > > Log: > BIOSes, buggy or otherwise, are i386 or amd64 specific. > Have the early USB takeover enabled for i386 and amd64 > by default. > This also avoids a panic on PowerPC where the resource > isn't released properly and we find a busy resource > when the USB host controller wants to allocate it... Presumably such systems won't set the 'BIOS owned' bit in the their legacy support registers in which case these routines are NOPs (they just read the register, see the bit is clear, and exit). The resource bug sounds like a real one that should be fixed and would probably affect any x86 systems who have USB disabled in the BIOS, so that should be fixed rather than papered over. Please revert. Note that the legacy support register stuff is part of the uhci/ohci/ehci specifications, and that the code to frob it has been part of the same drivers since their inception. If it had been an actual problem then it would have been disabled back when USB was enabled for other architectures. -- John Baldwin