Date: Mon, 18 Feb 2008 20:30:37 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_mount.c Message-ID: <86k5l2rrj6.fsf@ds4.des.no> In-Reply-To: <20080218142626.GI30694@comp.chem.msu.su> (Yar Tikhiy's message of "Mon\, 18 Feb 2008 17\:26\:26 %2B0300") References: <200802141704.m1EH4VL4099009@repoman.freebsd.org> <86y79i5syt.fsf@ds4.des.no> <20080218142626.GI30694@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
Yar Tikhiy <yar@comp.chem.msu.su> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > Can you guarantee that this will not f*** up the bootp / dhcp + > > nfsroot case? There are dragons in that code which were decidedly > > not funny to track down and fix. > Indeed; or, as a Russian proverb has it, "Just don't touch the sh*t, > and it won't stink". :-) But, fortunately, I've just had a chance to > test this WRT the NFS_ROOT case. Thank Daemon, that code path is much > clearer now than it used to be in the 4.4BSD days. In other words, "no", or possibly "I don't want to answer your question". There are at least two quite different code paths that may lead to having an NFS-mounted root file system. Since you won't give me a proper answer, I have to assume that you only tested the easy one, i.e. pxeboot with a GENERIC kernel; and in that case, as the person who unf***ed both of the NFSROOT code paths the last time around, I support Craig's request to have this backed out and properly reviewed. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86k5l2rrj6.fsf>