From owner-cvs-sys Sun Dec 10 07:47:58 1995 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id HAA19978 for cvs-sys-outgoing; Sun, 10 Dec 1995 07:47:58 -0800 (PST) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id HAA19901 Sun, 10 Dec 1995 07:46:11 -0800 (PST) Received: from sax.sax.de by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id QAA24518; Sun, 10 Dec 1995 16:09:55 +0100 Received: by sax.sax.de (8.6.11/8.6.12-s1) with UUCP id QAA11474; Sun, 10 Dec 1995 16:09:55 +0100 Received: (from j@localhost) by uriah.heep.sax.de (8.6.12/8.6.9) id PAA06047; Sun, 10 Dec 1995 15:31:45 +0100 From: J Wunsch Message-Id: <199512101431.PAA06047@uriah.heep.sax.de> Subject: Re: cvs commit: src/sys/net if_tun.c To: peter@jhome.DIALix.COM (Peter Wemm) Date: Sun, 10 Dec 1995 15:31:45 +0100 (MET) Cc: bde@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: from "Peter Wemm" at Dec 10, 95 01:37:10 pm X-Phone: +49-351-2012 669 X-Mailer: ELM [version 2.4 PL23] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-cvs-sys@FreeBSD.ORG Precedence: bulk As Peter Wemm wrote: > > > Removed an `#ifdef __FreeBSD__'. Hundreds, if not thousands of other > > FreeBSD-specific things aren't ifdefed. > > I think our source could stand a lot more cleanup in this way.. After > all, our sources are for FreeBSD, not GenericBSD or PortableBSD... > > Especially so, since we've not been consistant. I think the only real > place where this kind of thing needs to stay is where we've taken 3rd > party device drivers into our source that we dont maintain ourselves, and > have cross-machine and version portability built in (if_cx and cx.c for > example). pcvt, too. Please, don't remove the #if PCVT_FREEBSD stuff there. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)