Date: Sun, 04 Jan 2009 12:21:32 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Martin Wilke <miwi@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Eygene Ryabinkin <rea-fbsd@codelabs.ru>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/nrpe2 Makefile ports/net-mgmt/nrpe2/files nrpe2.in Message-ID: <49611A4C.9030804@FreeBSD.org> In-Reply-To: <200812252024.mBPKOhS1087071@repoman.freebsd.org> References: <200812252024.mBPKOhS1087071@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Martin Wilke wrote: > miwi 2008-12-25 20:24:43 UTC > > FreeBSD ports repository > > Modified files: > net-mgmt/nrpe2 Makefile > net-mgmt/nrpe2/files nrpe2.in > Log: > - Modify rc.d script to allow administrator to change PID file location > without editing rc.d script. New knob nrpe2_pidfile is provided for > this and it defaults to the old value of the PID file. > - Bump PORTREVISION > > PR: 129386 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=129386 > Submitted by: Eygene Ryabinkin <rea-fbsd@codelabs.ru> > Approved by: maintainer > > Revision Changes Path > 1.26 +1 -0 ports/net-mgmt/nrpe2/Makefile > 1.3 +5 -2 ports/net-mgmt/nrpe2/files/nrpe2.in > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nrpe2/Makefile.diff?&r1=1.25&r2=1.26&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/nrpe2/files/nrpe2.in.diff?&r1=1.2&r2=1.3&f=h Overall the rc.d file looks pretty good, just a couple notes. You need to move the load_rc_config line above the default variable assignments, otherwise it's not very effective. I'm also unclear as to why you have two assignments for command_args. Finally you might want to consult http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html hth, Doug -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49611A4C.9030804>