Date: Mon, 16 Jan 2006 20:03:13 +0200 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Sam Leffler <sam@errno.com> Cc: current@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: malloc bugs with tcpdump Message-ID: <20060116180312.GA1742@flame.pc> In-Reply-To: <43CBD81E.80006@errno.com> References: <20060116013722.GA29139@xor.obsecurity.org> <20060116135928.GB28974@flame.pc> <43CBD81E.80006@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2006-01-16 09:30, Sam Leffler <sam@errno.com> wrote:
> I sent the attached patch upstream to the tcpdump folks. Once I hear
> back I'll commit it.
Thanks :)
> Index: pcap-bpf.c
> ===================================================================
> RCS file: /usr/ncvs/src/contrib/libpcap/pcap-bpf.c,v
> retrieving revision 1.1.1.10
> diff -u -r1.1.1.10 pcap-bpf.c
> --- pcap-bpf.c 11 Jul 2005 03:24:42 -0000 1.1.1.10
> +++ pcap-bpf.c 16 Jan 2006 05:48:49 -0000
> @@ -746,7 +746,7 @@
> u_int i;
> int is_ethernet;
>
> - bdl.bfl_list = (u_int *) malloc(sizeof(u_int) * bdl.bfl_len + 1);
> + bdl.bfl_list = (u_int *) malloc(sizeof(u_int) * (bdl.bfl_len + 1));
> if (bdl.bfl_list == NULL) {
> (void)snprintf(ebuf, PCAP_ERRBUF_SIZE, "malloc: %s",
> pcap_strerror(errno));
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060116180312.GA1742>