From owner-freebsd-current@FreeBSD.ORG Mon Jul 11 15:09:07 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF80116A41C; Mon, 11 Jul 2005 15:09:07 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1072743D4C; Mon, 11 Jul 2005 15:09:06 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.40.201] (Not Verified[65.202.103.25]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Mon, 11 Jul 2005 11:23:09 -0400 From: John Baldwin To: "Wilkinson, Alex" Date: Mon, 11 Jul 2005 10:44:51 -0400 User-Agent: KMail/1.8 References: <200507090932.12973.jhb@FreeBSD.org> <20514.1120916772@phk.freebsd.dk> <20050710072752.GA39156@squash.dsto.defence.gov.au> In-Reply-To: <20050710072752.GA39156@squash.dsto.defence.gov.au> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200507111044.52693.jhb@FreeBSD.org> Cc: Poul-Henning Kamp , freebsd-current@freebsd.org, current@freebsd.org Subject: Re: [TEST/REVIEW] boot0cfg/fdisk issue fix X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2005 15:09:07 -0000 On Sunday 10 July 2005 03:27 am, Wilkinson, Alex wrote: > 0n Sat, Jul 09, 2005 at 03:46:12PM +0200, Poul-Henning Kamp wrote: > >In message <200507090932.12973.jhb@FreeBSD.org>, John Baldwin writes: > >>On Tuesday 05 July 2005 04:44 pm, Poul-Henning Kamp wrote: > >>> This is an attempt to fix an boot0cfg/fdisk issue which I have > >>> overlooked. > >>> > >>> The patch adds a g_ctl method to geom_mbr and makes boot0cfg and > >>> fdisk use it to modify the MBR if possible. > >>> > >>> Please test and report ASAP in order to get this solution into > >>> RELENG_6 > >> > >>Only thing I noted is that it seems that you changed boot0 to always > >> only write 512 bytes which means it will break trying to use > >> boot0cfg to install boot0ext (which is 2 sectors). Perhaps you > >> should check the filesize of the boot you are writing and if it's > > >> 512, write the other data with a write(2) after the g_ctl()? > >> Perhaps I don't see quite understand what your g_ctl() is doing > >> though. > > > >Damn, didn't think of that... > > what is boot0ext ? It's a 2-sector variant of boot0 that includes extra logic to choose between CHS and LBA BIOS calls and a longer table of filesystem/OS names. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org