Date: Thu, 16 Feb 2017 20:06:21 +0000 (UTC) From: Ryan Stone <rstone@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r313816 - head/sys/kern Message-ID: <201702162006.v1GK6LnX097532@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rstone Date: Thu Feb 16 20:06:21 2017 New Revision: 313816 URL: https://svnweb.freebsd.org/changeset/base/313816 Log: Fix a typo in my previous commit Somehow in the late stages of testing my sched_ule patch, a character was accidentally deleted from the file. Correct this. While I'm committing anyway, the previous commit message requires some clarification: in the normal case of unlending priority after releasing a mutex, the thread that was doing the lending will be woken up and immediately become the highest-priority thread, and in that case no priority inversion would take place. However, if that thread is pinned to a different CPU, then the currently running thread that just had its priority lowered will not be preempted and then priority inversion can occur. Reported by: O. Hartmann (typo), jhb (scheduler clarification) MFC after: 1 month Pointy hat to: rstone Modified: head/sys/kern/sched_ule.c Modified: head/sys/kern/sched_ule.c ============================================================================== --- head/sys/kern/sched_ule.c Thu Feb 16 19:58:02 2017 (r313815) +++ head/sys/kern/sched_ule.c Thu Feb 16 20:06:21 2017 (r313816) @@ -1047,7 +1047,7 @@ tdq_notify(struct tdq *tdq, int pri) if (tdq->tdq_ipipending) return; - cpu = TD_ID(tdq); + cpu = TDQ_ID(tdq); ctd = pcpu_find(cpu)->pc_curthread; if (!sched_shouldpreempt(pri, ctd->td_priority, 1)) return;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702162006.v1GK6LnX097532>