From owner-p4-projects Sat Jul 20 7:42:31 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 0DB8237B401; Sat, 20 Jul 2002 07:42:29 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A5B437B400 for ; Sat, 20 Jul 2002 07:42:28 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 48FAA43E4A for ; Sat, 20 Jul 2002 07:42:28 -0700 (PDT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6KEgRJU032141 for ; Sat, 20 Jul 2002 07:42:28 -0700 (PDT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6KEgRmg032137 for perforce@freebsd.org; Sat, 20 Jul 2002 07:42:27 -0700 (PDT) Date: Sat, 20 Jul 2002 07:42:27 -0700 (PDT) Message-Id: <200207201442.g6KEgRmg032137@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson Subject: PERFORCE change 14519 for review To: Perforce Change Reviews Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14519 Change 14519 by rwatson@rwatson_curry on 2002/07/20 07:41:26 Sadly, babyaudit is a victim of correct VFS locking: we can't invoke vn_fullpath() deep in a MAC module because we already hold sufficient vnode locks to give it a head ache. Releasing and re-acquiring those locks would open race conditions. Presumably a better solution would involve a record queue and a worker thread to avoid the locking issues, but I don't have time to implement that right now. Affected files ... .. //depot/projects/trustedbsd/mac/sys/security/babyaudit/babyaudit.c#10 delete Differences ... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message