Date: Wed, 18 Nov 2015 17:45:04 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r288966 - head/share/mk Message-ID: <564D29A0.6040000@FreeBSD.org> In-Reply-To: <56155FE0.7020809@FreeBSD.org> References: <201510070032.t970WYvU099368@repo.freebsd.org> <56146B4E.5040401@FreeBSD.org> <24053.1444240925@chaos> <56155FE0.7020809@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--dmpsXb8wNAdsRX9RoDdhIhIRBnD8fmou8
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 10/7/2015 11:09 AM, Bryan Drewery wrote:
> On 10/7/2015 11:02 AM, Simon J. Gerraty wrote:
>> Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>>>> +.for h in ${SRCS:M*.h}
>>>
>>> I think we can use DPSRCS as well for this.
>>
>> Not sure.
>> usr.bin/truss/Makefile didn't use that.
>> I only see it set in bsd.dep.mk - which we don't use in meta mode.
>>
>=20
> I'm less thinking about the usage in bsd.dep.mk and more these that
> manually set it:
>=20
> gnu/lib/libreadline/readline/Makefile:DPSRCS+=3D ${INSTALLED_HEADERS}
> lib/libc/tests/rpc/Makefile:DPSRCS+=3D h_testbits.h
> sbin/ipf/ipf/Makefile:DPSRCS+=3D ${GENHDRS}
> sbin/ipf/ipftest/Makefile:DPSRCS+=3D ${GENHDRS}
> sbin/ipf/ipmon/Makefile:DPSRCS+=3D ${GENHDRS}
> sbin/ipf/ipnat/Makefile:DPSRCS+=3D ${GENHDRS}
> sbin/ipf/ippool/Makefile:DPSRCS+=3D ${GENHDRS}
> sys/modules/linux/Makefile:DPSRCS=3D linux${SFX}_genassym.c
> sys/modules/linux64/Makefile:DPSRCS=3D linux_genassym.c
> sys/modules/vmm/Makefile:DPSRCS=3D vmx_genassym.c svm_genassym.c=
> usr.bin/kdump/Makefile:DPSRCS=3D kdump_subr.h
> usr.bin/netstat/Makefile:DPSRCS=3D nl_defs.h
> usr.bin/svn/svn/Makefile:DPSRCS+=3D freebsd-organization.h
>=20
>=20
> I ran into at least one case, I think usr.bin/netstat, where the file i=
n
> DPSRCS was missing and Makefile.depend had to learn how to build it
> before it would work.
>=20
> I can test more to see if adding it has any effect.
>=20
Actually, all but the sys/ ones here are wrongly using DPSRCS and should
be SRCS. I have pending commits to fix that. DPSRCS is *only for files
used to generate other files, not generated files*. Fixing these DPSRCS
cases fixes the "clean build" in usr.bin/netstat for example (without
the local deps in Makefile.depend). Really, anything that fails to build
with "missing local dependencies" is broken outside of the meta build as
well.
As for the actual change in local.autodep.mk, I don't think it is needed
or right since bsd.lib.mk and bsd.prog.mk already do exactly the same
thing via ${OBJS}: ${SRCS:M*.h} if .depend is not yet generated. This
does work in meta mode as I ran into a failure due to it before r291046
(I had removed the libbfd/Makefile.depend.host for other testing). It's
also hooked in far too late and orthogonally to the OBJS in the graph
that need the headers.
--=20
Regards,
Bryan Drewery
--dmpsXb8wNAdsRX9RoDdhIhIRBnD8fmou8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJWTSmgAAoJEDXXcbtuRpfPBXUH/jn/unMhFx+h++hXUnjcvFyj
f/ZaFI6+dHC9x15OYdqry8GFrcTADOkqcyOFMkRovVOlZIP3mlZ0WQeF4d2slPNU
Q6tA3R6guSSYpKRZG/Ej3RlrjSXzy6JKP9FjkTZsJSEdH4DyEKAuTjX/pBEEWIFc
5YM0aSAiSU16WKVwbk4cOxJolBphx0qnPQlubae8l+zCCV7gr01egcxcth0nQAzx
64aWtK4Bk/VrxNJ2rZo3cB+Gkj2C2KVI5+SUw0ABh6maYvBmCmexYcJvRKtQNIUF
vjiLSzIcHfO5uRSngxzMsmKHZqey9VsFxKfuEEocc7fdODl+JIC/LC4YzKtP888=
=Remo
-----END PGP SIGNATURE-----
--dmpsXb8wNAdsRX9RoDdhIhIRBnD8fmou8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?564D29A0.6040000>