From owner-svn-src-all@freebsd.org Thu Jul 12 22:59:04 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A888102CEA3; Thu, 12 Jul 2018 22:59:04 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pf0-x229.google.com (mail-pf0-x229.google.com [IPv6:2607:f8b0:400e:c00::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 192C6860E3; Thu, 12 Jul 2018 22:59:04 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pf0-x229.google.com with SMTP id u16-v6so21437067pfh.3; Thu, 12 Jul 2018 15:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sPIShR6YMRt8822wZN7qhX5/vHRJF7xCgt3D8pzVO10=; b=nnwvcegUaHkczKPXZgQygU8GwPNsOHcVJcilEYEgR8qM/9xLEFphboBqvfj8PbnN7u v936lAQE8ZfrzV6f0U5FtQwKV0HELM1339a8176Mg4WXtwzU6Mzx0WocTB1wVH/pvlU9 2sA+RCRoGA/traPXMnpAOwrf5mGStcmtOlmlMdRUt0vm7hXo5YtbFIuyQaVfCZnhPBah bkxbvC49lB7l01EjVTR04pPrYC+t+BLjg/P/Rg8BpL9yNK56U5lKDrqbSkIZK7Te2wel 6+sOXRLgMxwMaiEA2Qhf0TeEnuYQH524OuGmhb3K6/pbmXeahRNGbMydfMk8vxlV3DL4 IufA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=sPIShR6YMRt8822wZN7qhX5/vHRJF7xCgt3D8pzVO10=; b=JmMsGCTvz14WPgyz961SjXR5lgHjGzLzJLmF2KasD/D6jFyYt3v3ngh9088mA4M71+ 1b2NqAew4yPg+7haHxpR4IUVcyeMmjLmFLmLEGcQklHk1tmNyfnobMVA0PWmhKbrpSLS VNu/6v8Kwwk50AXnGZKS9BkcH4NkAAk7L2Pzj1AQKXfD45FMu7vxCZAz5vPOy225ReGB OpMNOgY4su8cvd3i7ro6geaQMIkEKkYfNNtMbvy1YWmR+kP4GGy8tMUIywEKmmMdOOJ/ CswEN1cqH/KRnLw8//YyHFylrEMvq8D3D8kh8aRL5MoLcrbVj7IJlSM7yS4bRWb9en3J J3ZA== X-Gm-Message-State: AOUpUlF6OMuGm/m60utg9L9LiQapgr7WZKQHklR21OsG3O9zHNrSnvqb 2PUIIODWSydnDD8Qmy0jFujLcxHM X-Google-Smtp-Source: AAOMgpdpP7H9bxAcqUsugSGkTD0uqv3NdGOg4gtQTkE3c+wxNnv8dzr4GYiIklYMVrl8mSHL+bXhOg== X-Received: by 2002:a62:4dc5:: with SMTP id a188-v6mr4362378pfb.217.1531436342648; Thu, 12 Jul 2018 15:59:02 -0700 (PDT) Received: from raichu (toroon0560w-lp130-09-70-52-224-107.dsl.bell.ca. [70.52.224.107]) by smtp.gmail.com with ESMTPSA id e16-v6sm2261958pga.2.2018.07.12.15.59.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jul 2018 15:59:01 -0700 (PDT) Sender: Mark Johnston Date: Thu, 12 Jul 2018 18:58:56 -0400 From: Mark Johnston To: Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336231 - head/sys/vm Message-ID: <20180712225856.GA26064@raichu> References: <201807122235.w6CMZqO8030291@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201807122235.w6CMZqO8030291@repo.freebsd.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 22:59:04 -0000 On Thu, Jul 12, 2018 at 10:35:52PM +0000, Mateusz Guzik wrote: > Author: mjg > Date: Thu Jul 12 22:35:52 2018 > New Revision: 336231 > URL: https://svnweb.freebsd.org/changeset/base/336231 > > Log: > uma: whack main zone counter update in the slow path, freeing side > > See r333052. > > Modified: > head/sys/vm/uma_core.c > > Modified: head/sys/vm/uma_core.c > ============================================================================== > --- head/sys/vm/uma_core.c Thu Jul 12 22:34:40 2018 (r336230) > +++ head/sys/vm/uma_core.c Thu Jul 12 22:35:52 2018 (r336231) > @@ -3135,14 +3135,6 @@ zfree_start: > cpu = curcpu; > cache = &zone->uz_cpu[cpu]; > > - /* > - * Since we have locked the zone we may as well send back our stats. > - */ > - atomic_add_long(&zone->uz_allocs, cache->uc_allocs); > - atomic_add_long(&zone->uz_frees, cache->uc_frees); > - cache->uc_allocs = 0; > - cache->uc_frees = 0; > - Doesn't this break the accounting of these stats? uma_reclaim() doesn't update them when it frees cached items, and uma_zone_get_cur() doesn't look at the stats for cached buckets.