Date: Sat, 12 Mar 2011 23:37:20 GMT From: Eitan Adler <lists@eitanadler.com> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/155502: [patch] remove sanity check for X_WINDOW_SYSTEM Message-ID: <201103122337.p2CNbKHr004357@red.freebsd.org> Resent-Message-ID: <201103122340.p2CNeBQ2037972@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 155502
>Category: misc
>Synopsis: [patch] remove sanity check for X_WINDOW_SYSTEM
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 12 23:40:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Eitan Adler
>Release:
>Organization:
>Environment:
>Description:
A check to see if X_WINDOW_SYSTEM is defined has been in b.p.m since 2008 when flz committed it. The variable is not used anywhere in the ports tree now and the check deserves to be removed.
1.590 (flz 07-Mar-08): .if defined(X_WINDOW_SYSTEM) && ${X_WINDOW_SYSTEM:L} != "xorg"
1.590 (flz 07-Mar-08): IGNORE= cannot be installed: bad X_WINDOW_SYSTEM setting; valid value is 'xorg'
1.566 (flz 19-May-07): .endif
>How-To-Repeat:
>Fix:
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.674
diff -u -r1.674 bsd.port.mk
--- bsd.port.mk 7 Mar 2011 07:32:05 -0000 1.674
+++ bsd.port.mk 12 Mar 2011 23:18:54 -0000
@@ -1396,10 +1396,6 @@
.include "${PORTSDIR}/Mk/bsd.linux-apps.mk"
.endif
-.if defined(X_WINDOW_SYSTEM) && ${X_WINDOW_SYSTEM:L} != "xorg"
-IGNORE= cannot be installed: bad X_WINDOW_SYSTEM setting; valid value is 'xorg'
-.endif
-
.if ${X11BASE} != ${LOCALBASE}
.BEGIN:
@${ECHO_MSG} "X11BASE is now deprecated. Unset X11BASE in make.conf and try again."
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103122337.p2CNbKHr004357>