Date: Wed, 20 Mar 1996 20:14:10 +0100 (MET) From: Andreas Klemm <andreas@knobel.gun.de> To: J Wunsch <j@uriah.heep.sax.de> Cc: Lars_Koeller@odie.physik2.uni-rostock.de, ports@FreeBSD.ORG Subject: Re: xperfmon doesn't compile on FreeBSD-current (incl. PATCH) Message-ID: <Pine.BSF.3.91.960320200813.18629D-100000@knobel.gun.de> In-Reply-To: <199603201830.TAA09103@uriah.heep.sax.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 20 Mar 1996, J Wunsch wrote: > As Andreas Klemm wrote: > > > size = sizeof(nfsstats); > > +#ifdef HAS_CTL_VFS > > + mib[0] = CTL_VFS; > > +#else > > mib[0] = CTL_FS; > > +#endif > > I assume ``CTL_VFS'' is already a #define. In this case, why not > simply do: > > #ifndef HAS_CTL_VFS > # define HAS_CTL_VFS HAS_CTL_FS > #endif That's surely another way to do it. But then one should add a comment, so thats evident for everyone, that this is a FreeBSD - or should I better say BSD 4.4 lite or even an NFS 3.0 code - related hack ? My intention defining HAS_CTL_VFS at that point, where the exact release of FreeBSD already was fiddled out, was to show, that this define is only true under -current. An alternative would be to take your shorter one, Joerg and to add a comment. I like well documented programs ;-) Andreas /// -- andreas@knobel.gun.de /\/\___ Wiechers & Partner Datentechnik GmbH Andreas Klemm ___/\/\/ $$ Support Unix - aklemm@wup.de $$ pgp p-key http://www-swiss.ai.mit.edu/~bal/pks-toplev.html >>> powered by <<< ftp://sunsite.unc.edu/pub/Linux/system/Printing/aps-491.tgz >>> FreeBSD <<< "Ich bleibe bei der Aussage und trotze den Flames. :-)" Ulli Horlacher 02/96
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.91.960320200813.18629D-100000>