Date: Wed, 27 Apr 2005 09:02:30 +0200 From: Jose M Rodriguez <josemi@freebsd.jazztel.es> To: freebsd-current@freebsd.org Cc: Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: rigth crc32 implementation Message-ID: <200504270902.31464.josemi@redesjm.local> In-Reply-To: <426F2562.2090008@freebsd.org> References: <200504261143.55195.josemi@redesjm.local> <200504270052.33158.josemi@redesjm.local> <426F2562.2090008@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
El Mi=E9rcoles, 27 de Abril de 2005 07:38, Tim Kientzle escribi=F3: > Jose M Rodriguez wrote: > > El Mi=C3=A9rcoles, 27 de Abril de 2005 00:19, Marcel Moolenaar=20 escribi=C3=B3: > >>On Tue, Apr 26, 2005 at 01:01:32PM -0700, Sam Leffler wrote: > >>>Note also there is CRC32 code of this sort in WEP and TKIP crypto > >>>modules in the net80211 support. > >> > >>Given the seperation of crc32() into crc32_raw() and crc32(), with > >>either crc32() only or otherwise both functions inlined, are there > >>any obstacles preventing the 802.11 code from using the ones in > >>src/sys/libkern? > > > > at last, sys/dev/if_sbni have another implementation of what seems > > to be a crc32 alg. > > Be a little careful, please. There are very many > different, incompatible "32-bit CRCs." There are > just a few popular ones, so you can often combine > functions, but not always. > I'm getting this. I'll try to do some test and notes. I think that a regression test may show what is and what is not the=20 ether CRC-32. At the moment, I'll go private with =2D CRC_INIT, CRC_DO, CRC_GET macros =2D An implementation in the way of crc32(), crc32_raw(), but avoiding=20 symbol collission. And go to libkern through the macros if doable. =2D- josemi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200504270902.31464.josemi>