From owner-svn-ports-head@FreeBSD.ORG Wed Dec 5 01:46:15 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 699A2A06 for ; Wed, 5 Dec 2012 01:46:15 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id CB15E8FC12 for ; Wed, 5 Dec 2012 01:46:14 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id j13so4841190lah.13 for ; Tue, 04 Dec 2012 17:46:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=+fzw9ONEBlwtprGuTkf/GtYX/qPwA5BWXVG3q8YK4TU=; b=r2dhvsWoqemETibSiCGBNvLSl+zk4Zu4+zZjbfB67x3wfm9yQQUQmheUnlwkDG69vE LZ9v9u1d6a/gpp6VbiZ4oEA4ujWwAbI5t3XVPVTQSC2DopwxdCKlO5ecrtyvedwLugmd yk/pJNNgXUpML6O1BIGBVNy65mObaNg9olqkw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=+fzw9ONEBlwtprGuTkf/GtYX/qPwA5BWXVG3q8YK4TU=; b=SZI0jngREZuNur3yjK251jntVAARE96Cx6roqYnrbak6fRqKN11GuxM00hwhLqOIbo eIGppN2o1AI93mQU5S5Qbl+9Fgt8D/661Rk6kEtRZNJp3pQQVOTfQCS6CGsHFSrfWaK2 1vThBxjsxJe4HFro2HXilZAmd0phVN3k8WbfxpvyvQILRmCcdvsFTa/5HAK7qXG2MMlC DBVV/1g1nypC+f5ZG/AhNOLq4aZHdMdQiWFZe29i+eAJ1/8mUMpp6/7pDG7n19Rb+p1I pRXlg4s15BpX6i6OV6cClksNjhhNlkxDbDgHLuZmgai5fj1PSD1ROUlNibUg5xY/+7XJ XTnQ== Received: by 10.152.105.173 with SMTP id gn13mr14966700lab.41.1354671973702; Tue, 04 Dec 2012 17:46:13 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.110.225 with HTTP; Tue, 4 Dec 2012 17:45:43 -0800 (PST) In-Reply-To: <20121205012842.GB45591@FreeBSD.org> References: <201212041815.qB4IFB55053423@svn.freebsd.org> <20121205012842.GB45591@FreeBSD.org> From: Eitan Adler Date: Tue, 4 Dec 2012 20:45:43 -0500 X-Google-Sender-Auth: lK0WKC5nix7wMvY8eDvphk5NOak Message-ID: Subject: Re: svn commit: r308260 - head/net-mgmt/p5-Net-IP To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnmp/Iq9WeflCMa9PnV8HJRsd97IEgAn7iqAsTAJuedbsE8cn7mtyocsGUVu11Zxg9b1ft4 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Chris Rees , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2012 01:46:15 -0000 On 4 December 2012 20:28, Alexey Dokuchaev wrote: > On Tue, Dec 04, 2012 at 06:54:18PM +0000, Chris Rees wrote: >> On 4 Dec 2012 18:15, "Eitan Adler" wrote: >> > post-patch: >> > - @${CP} ${WRKSRC}/IP.pm ${WRKSRC}/IP.pm.presed >> > - @${SED} -e "1853s#\\s+#\s*#g" ${WRKSRC}/IP.pm.presed > \ >> > - ${WRKSRC}/IP.pm >> > - @${CP} ${WRKSRC}/ipcount ${WRKSRC}/ipcount.presed >> > - @${SED} -e "76s#count#count = 0#" ${WRKSRC}/ipcount.presed > \ >> > - ${WRKSRC}/ipcount >> > + ${REINPLACE_CMD} "1853s#\\s+#\s*#g" ${WRKSRC}/IP.pm >> > + ${REINPLACE_CMD} "76s#count#count = 0#" ${WRKSRC}/ipcount >> >> These are horrible- why not patches? > > There *were* horrible; now they are pretty much clear and trivial. While it > is largely the matter of taste, I also prefer to perform simple mechanical > changes with sed(1) and use patches for some more complicated logic. They remain horrible because they use sed to modify a specific line. That said, I'll leave them for now and revisit when I update the port. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams