From owner-svn-ports-head@FreeBSD.ORG  Tue May  7 01:40:34 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id A95A751E; Tue,  7 May 2013 01:40:34 +0000 (UTC)
Date: Tue, 7 May 2013 01:40:34 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jimmy Olgeni <olgeni@FreeBSD.org>
Subject: Re: svn commit: r317548 - head/lang/erlang
Message-ID: <20130507014034.GB14600@FreeBSD.org>
References: <201305062018.r46KIXbK048584@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201305062018.r46KIXbK048584@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 May 2013 01:40:34 -0000

On Mon, May 06, 2013 at 08:18:33PM +0000, Jimmy Olgeni wrote:
> New Revision: 317548
> URL: http://svnweb.freebsd.org/changeset/ports/317548
> 
> Log:
>   Do not try to install empty DOCSDIR.
> 
> @@ -200,8 +200,8 @@ post-install:
>  	@${INSTALL_DATA} ${WRKSRC}/lib/dialyzer/doc/*.txt \
>  		${PREFIX}/lib/${ERLANG_LIB}/lib/dialyzer-*/doc/
>  
> -	@${MKDIR} ${DOCSDIR}
>  .for FILE in ${DOC_DISTFILES}
> +	@${MKDIR} ${DOCSDIR}
>  	@${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/$$(expr ${FILE} : '\([^:]*\)') ${DOCSDIR}
>  .endfor
>  .endif

I don't quite understand this change.  Why move mkdir inside the loop?
How is can be empty when the whole thing is already inside .if
${PORT_OPTIONS:MDOCS}?

The port itself could probably benefit from some cleaning and fixing of
several style bugs.

./danfe