Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Mar 2016 03:28:58 +0000 (UTC)
From:      Cy Schubert <cy@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r296299 - head/sys/contrib/ipfilter/netinet
Message-ID:  <201603020328.u223SwLU036267@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: cy
Date: Wed Mar  2 03:28:57 2016
New Revision: 296299
URL: https://svnweb.freebsd.org/changeset/base/296299

Log:
  Remove redundant NULL pointer comparison.
  
  Reported  by:		PVS-Studio (V595) in D5245
  Differential Revision:	D5245

Modified:
  head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c

Modified: head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c
==============================================================================
--- head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c	Wed Mar  2 03:26:56 2016	(r296298)
+++ head/sys/contrib/ipfilter/netinet/ip_ftp_pxy.c	Wed Mar  2 03:28:57 2016	(r296299)
@@ -1951,10 +1951,6 @@ ipf_p_ftp_epsv(softf, fin, ip, nat, ftp,
 		ap += *s++ - '0';
 	}
 
-	if (!s) {
-		return 0;
-}
-
 	if (*s == '|')
 		s++;
 	if (*s == ')')



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201603020328.u223SwLU036267>