Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Feb 2009 11:55:48 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        freebsd-arch@freebsd.org
Cc:        Andriy Gapon <avg@icyb.net.ua>
Subject:   Re: Trimming the default /boot/device.hints
Message-ID:  <200902061155.48705.jhb@freebsd.org>
In-Reply-To: <200902061143.10088.jhb@freebsd.org>
References:  <200901260947.32870.jhb@freebsd.org> <498C55BB.3030606@icyb.net.ua> <200902061143.10088.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 06 February 2009 11:43:09 am John Baldwin wrote:
> On Friday 06 February 2009 10:22:35 am Andriy Gapon wrote:
> > on 06/02/2009 16:37 John Baldwin said the following:
> > > 
> > > Yes, it only needs the hint for it to be a console device.
> > > 
> > 
> > I am slightly confused as to how that hint works then, it's not like a
> > standard isa hint it seems.
> > Can it somehow be built-in (into the code)?
> 
> Specifically, look at sc_cnprobe() in sys/dev/syscons/syscons.c.  It calls a 
> sc_cons_get_priority() routine that on x86 maps lives in 
> sys/isa/syscons_isa.c.  This checks for a syscons hint.  Changing it to 
> always assume a unit 0 would probably allow this to work.

Something like this (untested):

--- //depot/user/jhb/acpipci/isa/syscons_isa.c
+++ /home/jhb/work/p4/acpipci/isa/syscons_isa.c
@@ -238,8 +238,10 @@
 			*flags = f;
 		}
 	}
-	if (*unit < 0)
-		return CN_DEAD;
+	if (*unit < 0) {
+		*unit = 0;
+		*flags = 0;
+	}
 #if 0
 	return ((*flags & SC_KERNEL_CONSOLE) ? CN_INTERNAL : CN_NORMAL);
 #endif


-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902061155.48705.jhb>