Date: Fri, 1 Apr 2016 10:25:21 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: Bryan Drewery <bdrewery@freebsd.org>, FreeBSD Toolchain <freebsd-toolchain@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>, Gerald Pfeifer <gerald@FreeBSD.org>, FreeBSD PowerPC ML <freebsd-ppc@freebsd.org>, Mark Millard <markmi@dsl-only.net> Subject: Re: svn commit: r297435 - head: still problems for stage 3 when gcc 4.2.1 is avoided (powerpc64 self-hosted build) Message-ID: <5FDFDC6A-911B-4A77-BCEF-BBB711BFA0AC@FreeBSD.org> In-Reply-To: <DD2A166A-28D3-4F97-A084-6109B0BA21CC@bsdimp.com> References: <5A0ACA76-6F1D-4975-9E59-2A64BB8EFC77@dsl-only.net> <56FD9757.6040709@FreeBSD.org> <9E3033D5-F416-4B78-97C2-0A0AABF5A49E@dsl-only.net> <56FDA5F9.1090601@FreeBSD.org> <DD2A166A-28D3-4F97-A084-6109B0BA21CC@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_A95B8F40-09B8-483E-B4C8-EA591BCA8042 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 01 Apr 2016, at 00:44, Warner Losh <imp@bsdimp.com> wrote: >=20 >> On Mar 31, 2016, at 4:34 PM, Bryan Drewery <bdrewery@freebsd.org> = wrote: >> I didn't realize the ports compiler was defaulting /usr/local/include >> into the search path now. It does not have /usr/local/lib in the >> default library path as far as I can tell. It's also broken for its >> -rpath (noted in its pkg-message). So having a default >> /usr/local/include path seems odd. >=20 > It has for a while now. It=E2=80=99s one of the maddening = inconsistencies that abound in this > area. I took a poll a while ago and there seemed to be widespread = support for adding > it to the base compiler. This was the main reason /usr/local/include was *not* included in the base compiler, otherwise it would unpredictably pick up headers in /usr/local/include during builds. You can never know which conflicting headers a certain user has installed in /usr/local/include... :) >> Adding -isystem /usr/include to fix this is probably possible but >> there's a risk someone will remove it as redundant. In this case I = wish >> /usr/include was first but I'm not sure what impact that would have = on >> consumers expecting /usr/local/include (and /usr/local/lib) overrides = to >> work, though they would need to pass a -L /usr/local/lib anyhow and >> would likely be passing -I /usr/local/lib too. >=20 > /usr/include should be first. But it isn=E2=80=99t. That=E2=80=99s = another inconsistency that was found > when we looked at /usr/local stuff. Someone recently added = /usr/local/bin to the path, > if I recall correctly. Isn't that a bit of a bikeshed? I guess some people would just as well prefer /usr/local/include to be first, just like some people prefer /usr/local/bin before /usr/bin in their PATH. In any case, if such paths are added to external compilers, we better make sure almost everything in buildworld uses -nostdinc, and specifying exactly the include directories we need, and no others. Cumbersome, but maybe for a good cause. -Dimitry --Apple-Mail=_A95B8F40-09B8-483E-B4C8-EA591BCA8042 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.29 iEYEARECAAYFAlb+MHkACgkQsF6jCi4glqNjHgCgsJZMqs4Te2EV2NDcadXNc8ps miUAoPSWYhEHQHgVem89zyv2uzETotf7 =Q3vy -----END PGP SIGNATURE----- --Apple-Mail=_A95B8F40-09B8-483E-B4C8-EA591BCA8042--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5FDFDC6A-911B-4A77-BCEF-BBB711BFA0AC>