Date: Tue, 20 Dec 2011 09:51:43 +1100 From: Peter Jeremy <peterjeremy@acm.org> To: Michiel Boland <boland37@xs4all.nl> Cc: freebsd-stable@freebsd.org Subject: Re: fsck_ufs out of swapspace Message-ID: <20111219225143.GD2391@server.vk2pj.dyndns.org> In-Reply-To: <4EEFAC55.6050507@xs4all.nl> References: <4EECFD6A.2030905@xs4all.nl> <2E07A04E-0FBF-47BE-96E7-F615FE78056E@gromit.dlib.vt.edu> <4EEFAC55.6050507@xs4all.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--w7PDEPdKQumQfZlR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2011-Dec-19 22:27:49 +0100, Michiel Boland <boland37@xs4all.nl> wrote: >Problem solved - it was indeed an endian thing. >The problem is that fsck uses a real_dev_bsize variable that is declared l= ong,=20 >but the DIOCGSECTORSIZE ioctl takes an u_int argument. To be accurate, this isn't an endian problem, it's a general problem of passing a pointer to an incorrectly sized object. The bug is masked on amd64 & iA64 because real_dev_bsize is statically allocated and therefore initialised to zero. This means the failure to assign the top 32 bits in the ioctl doesn't affect the final result. >A PR has been submitted. sparc64/163460 for the record. Thank you for tracking that down. --=20 Peter Jeremy --w7PDEPdKQumQfZlR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk7vv/8ACgkQ/opHv/APuIcaJgCePunwxB4xMLMy7nq7FctnaBdt t18AoJVcekBR/Kb4d023spEGYUqV6joL =TzXh -----END PGP SIGNATURE----- --w7PDEPdKQumQfZlR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111219225143.GD2391>