From owner-freebsd-ports-bugs@freebsd.org Tue Jun 30 10:44:34 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AD77836567A for ; Tue, 30 Jun 2020 10:44:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 49x1FZ4CS5z4FX7 for ; Tue, 30 Jun 2020 10:44:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 8E93836587F; Tue, 30 Jun 2020 10:44:34 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8E5A3365C03 for ; Tue, 30 Jun 2020 10:44:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49x1FZ3L6Cz4FV4 for ; Tue, 30 Jun 2020 10:44:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 51D531710F for ; Tue, 30 Jun 2020 10:44:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 05UAiYVF076035 for ; Tue, 30 Jun 2020 10:44:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 05UAiY2T076034 for ports-bugs@FreeBSD.org; Tue, 30 Jun 2020 10:44:34 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 247626] net/py-wsdd: Update to 0.6.1 Date: Tue, 30 Jun 2020 10:44:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jdc@koitsu.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2020 10:44:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247626 --- Comment #5 from Jeremy Chadwick --- Three things: 1. Just some feedback: regarding the variable name (wsdd_suppflags): I had = the same conundrum. :) I'm not sure what to call it either. I might suggest looking through some other ports to see, although it might be difficult bec= ause there's only a limited number which use daemon(8). So, I think wsdd_suppfl= ags is fine. The other variables look very reasonable -- zero complaints! 2. I would suggest adding NETWORKING and SERVERS to the REQUIRE line. This= can affect rcorder(8). I know only DAEMON works as-is, but there is no guaran= tee of that long-term depending on if there are revamps in the future. We also must consider possibility of jail usage, where IIRC behaviours are differen= t.=20 I suggest looking at /etc/rc.d/* for examples. I just know that the 3 comb= ined will always do the right thing. 3. Someone (I can do this if it makes your life easier) should submit the w= sdd rc script modifications, when finished, back to the author in GitHub, so th= at there's at least some uniformity. FreeNAS may eventually pick that up too (their wsdd version right now is old and using an equally old service model, based entirely on what's in GitHub I think and not what's in ports). Thank you for your attentivity! It's greatly appreciated. --=20 You are receiving this mail because: You are the assignee for the bug.=