Date: Sat, 18 Aug 2007 20:27:48 GMT From: "Constantine A. Murenin" <cnst@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 125323 for review Message-ID: <200708182027.l7IKRmdX074380@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=125323 Change 125323 by cnst@dale on 2007/08/18 20:27:10 declaring sc_dev as a member of softc and leaving it completely uninitialised is dangerous; in fact, it caused me a few page-traps and reboots when I was converting it to my framework Affected files ... .. //depot/projects/soc2007/cnst-sensors/sys.dev.coretemp/coretemp.c#2 edit Differences ... ==== //depot/projects/soc2007/cnst-sensors/sys.dev.coretemp/coretemp.c#2 (text+ko) ==== @@ -136,6 +136,8 @@ int cpu_model; int cpu_mask; + sc->sc_dev = dev; + pdev = device_get_parent(dev); cpu_model = (cpu_id >> 4) & 15;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200708182027.l7IKRmdX074380>