Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Apr 2003 15:58:53 -0600 (CST)
From:      Mike Silbersack <silby@silby.com>
To:        Peter Jeremy <peterjeremy@optushome.com.au>
Cc:        Stephen McKay <smckay@internode.on.net>
Subject:   Re: cvs commit: src/sbin/ping ping.8 ping.c src/share/man/man4    inet.4 ip.4 src/sys/netinet in.h in_pcb.h ip.h ip_input.c ip_output.c    ip_var.h src/usr.bin/netstat inet.c
Message-ID:  <20030402155327.R662@odysseus.silby.com>
In-Reply-To: <20030402200546.GA31752@cirb503493.alcatel.com.au>
References:  <200304010821.h318Li4Q091687@repoman.freebsd.org>    <200304021447.h32ElHYH008677@dungeon.home> <20030402200546.GA31752@cirb503493.alcatel.com.au>

next in thread | previous in thread | raw e-mail | index | archive | help

On Thu, 3 Apr 2003, Peter Jeremy wrote:

> >Can we have this invisibly un-commited?
>
> If you mean "make it so it never happened" then I don't believe this
> is possible.  To explain, the change means that ping.c (for example)
> has gone from rev 1.91 to rev 1.92 - and this change has been fairly
> widely disseminated:  Lots of people will have CVSup'd it and it's
> in the CTM history.  If it "never happened" then ping.c will revert
> to rev 1.91 (etc).  Firstly, I believe CVS doesn't cope well with
> this sort of thing.  Secondly, the next person to commit to ping.c
> will create rev 1.92 - meaning that there are two different rev 1.92
> versions in existence.

Hasn't this been done to fix up botched commits in other parts of the
tree?

> IMHO, this joke isn't so off-colour that it has to disappear from the
> repository.  I agree that this joke has probably outlived its purpose
> but a normal backout should be sufficient for this.
>
> Peter

It's an eyesore in the cvs logs, and it's going to be a point of annoyance
for anyone who is looking back through them in the future.  Right now you
have to scroll down two pages before you see the last real change to
ip_output.c in cvsweb.

But, if such a rollback would break too many things, I can live with it,
assuming that such pranks *never happen again*.

Mike "Silby" Silbersack



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030402155327.R662>