Date: Wed, 01 Jun 2005 20:42:19 +0300 From: Maxim Sobolev <sobomax@portaone.com> To: Scott Long <scottl@samsco.org> Cc: cvs-src@FreeBSD.ORG, Tim Kientzle <kientzle@FreeBSD.ORG>, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libarchive archive_private.h archive_read.c archive_read_data_into_fd.c archive_write.c archive_write_set_compression_bzip2.c archive_write_set_compression_gzip.c archive_write_set_compression_none.c Message-ID: <429DF37B.8010203@portaone.com> In-Reply-To: <429DED77.9050003@samsco.org> References: <200506011552.j51FqdR2046893@repoman.freebsd.org> <429DED77.9050003@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I think extending tinderbox to add into CC all people who have committed into files that have changed since the last successful build will help to improve situation a lot. This should be pretty easy to do - after the buld is complete dig out revisions of all source files (by direct parsing of CVS/Entries) and save it into some persistent location. If the next build breaks, again make such list and for files whose versions differ do cvs log, parse results and compile the list of people to be notified from it. -Maxim Scott Long wrote: > Tim Kientzle wrote: > >> kientzle 2005-06-01 15:52:39 UTC >> >> FreeBSD src repository >> >> Modified files: >> lib/libarchive archive_private.h archive_read.c >> archive_read_data_into_fd.c >> archive_write.c >> archive_write_set_compression_bzip2.c >> archive_write_set_compression_gzip.c >> archive_write_set_compression_none.c Log: >> Remove the C99-specific __func__ that is one of the few barrier to >> compiling on IRIX and Solaris. Remove the "archive_check_magic" macro >> that existed only to provide __func__ to the underlying >> __archive_check_magic >> function. >> Thanks to: Darin Broady >> MFC after: 14 days >> Revision Changes Path >> 1.18 +17 -15 src/lib/libarchive/archive_private.h >> 1.15 +10 -10 src/lib/libarchive/archive_read.c >> 1.8 +1 -1 src/lib/libarchive/archive_read_data_into_fd.c >> 1.15 +8 -8 src/lib/libarchive/archive_write.c >> 1.8 +1 -1 >> src/lib/libarchive/archive_write_set_compression_bzip2.c >> 1.10 +1 -1 >> src/lib/libarchive/archive_write_set_compression_gzip.c >> 1.8 +1 -1 >> src/lib/libarchive/archive_write_set_compression_none.c > > > One of these last two commits breaks the build: > > /usr/obj/usr/src/tmp/usr/lib/libarchive.a(archive_write_set_format_pax.o)(.text+0xea7): > In function `archive_write_pax_header': > : undefined reference to `archive_entry_ctime_nsec' > /usr/obj/usr/src/tmp/usr/lib/libarchive.a(archive_write_set_format_pax.o)(.text+0xeb7): > In function `archive_write_pax_header': > : undefined reference to `archive_entry_ctime' > > I'm getting really really tired of the build breaking practically every > day. Every time I go to make a 6-CURRENT snapshot for release, I get > stopped up by all of this stupid stupid stupid breakage. I'm getting > really tired of it. Anyone who is wondering where the monthly snapshots > for the last few months have gone, it's because the build is broken and > I get tired of trying to fix it. > > > Scott > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?429DF37B.8010203>