From owner-freebsd-arch@FreeBSD.ORG Sat May 19 13:40:10 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6591C106564A; Sat, 19 May 2012 13:40:10 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id BCE878FC12; Sat, 19 May 2012 13:40:09 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q4JDe628092431; Sat, 19 May 2012 16:40:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q4JDe5X9099174; Sat, 19 May 2012 16:40:05 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q4JDe5WI099173; Sat, 19 May 2012 16:40:05 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 19 May 2012 16:40:05 +0300 From: Konstantin Belousov To: Robert Millan Message-ID: <20120519134005.GJ2358@deviant.kiev.zoral.com.ua> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="A/JKaSqKPqQLCbw0" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-arch@freebsd.org Subject: Re: headers that use "struct bintime" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 May 2012 13:40:10 -0000 --A/JKaSqKPqQLCbw0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 19, 2012 at 03:33:03PM +0200, Robert Millan wrote: > "struct bintime" is enabled only by __BSD_VISIBLE. However, there are > a few headers that use "struct bintime" without __BSD_VISIBLE: >=20 > sys/arm/include/cpu.h > sys/dev/iscsi/initiator/iscsivar.h > sys/geom/journal/g_journal.h > sys/sys/dtrace_bsd.h > sys/sys/devicestat.h > sys/sys/timeet.h > sys/sys/bio.h > sys/opencrypto/cryptodev.h >=20 > Should the definitions that use "struct bintime" be __BSD_VISIBLE too? > Or maybe "struct bintime" be defined unconditionally? >=20 > Or perhaps we could have "struct __bintime" and use that for system heade= rs? Note that all headers you listed are kernel headers, and kernel is exposed to the whole namespace. I suspect that no headers are supposed to be used by usermode among the list. --A/JKaSqKPqQLCbw0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+3orUACgkQC3+MBN1Mb4htWwCeJV9AuH/VdC4OzaZlZSxg8cx8 vAkAnRG0joEKCMYHhJpai0ROGv79nXUQ =5ZIi -----END PGP SIGNATURE----- --A/JKaSqKPqQLCbw0--