From owner-freebsd-current@FreeBSD.ORG Wed Jan 7 22:48:51 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CF6916A4D2 for ; Wed, 7 Jan 2004 22:48:51 -0800 (PST) Received: from email01.aon.at (WARSL402PIP8.highway.telekom.at [195.3.96.97]) by mx1.FreeBSD.org (Postfix) with SMTP id A47E343D53 for ; Wed, 7 Jan 2004 22:48:47 -0800 (PST) (envelope-from shoesoft@gmx.net) Received: (qmail 124056 invoked from network); 7 Jan 2004 21:16:15 -0000 Received: from m106p018.dipool.highway.telekom.at (HELO ?62.46.3.50?) ([62.46.3.50]) (envelope-sender ) by qmail1rs.highway.telekom.at (qmail-ldap-1.03) with SMTP for ; 7 Jan 2004 21:16:15 -0000 From: Stefan Ehmann To: Don Lewis In-Reply-To: <200401072015.i07KFl7E017500@gw.catspoiler.org> References: <200401072015.i07KFl7E017500@gw.catspoiler.org> Content-Type: text/plain Message-Id: <1073510185.707.8.camel@shoeserv.freebsd> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Wed, 07 Jan 2004 22:16:26 +0100 Content-Transfer-Encoding: 7bit cc: current@FreeBSD.org Subject: Re: sound/pcm/* bugs (was: Re: page fault panic tracked down (selwakeuppri()) - really sound/pcm/*) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jan 2004 06:48:51 -0000 On Wed, 2004-01-07 at 21:15, Don Lewis wrote: > Try the following patch. I won't guarantee that you still won't see > panics, but at least it should panic cleanly instead of stomping on some > innocent block of memory that corrupts data or some critical structure > that will trigger a mysterious and hard to debug panic at some later > time. > > The reason for changing the KASSERT to a test and an explicit call to > panic() is to make sure that the error is always caught because the > sound code is typically not compiled with INVARIANTS, so the KASSERT > will typically be ignored. The vchan stuff really needs a proper fix, > but I don't understand the sound code well enough. Nice patch - unfortunately sound doesn't work any longer with vchans enabled (which is set to 4 at boot time here). I get "pcm0:virtual:0: play interrupt timeout, channel dead" whenever I try to play anything. However, if I do "hw.snd.pcm0.vchans: 4 -> 0" it works nice again. I'll probably try later if I'm able to get a panic with vchans disabled (Especially those that had - at least not in an obvious way - any sound stuff in backtrace) If not, maybe the panic gets triggered if for some reason the dsp device isn't ready again after a song played and a new virtual dsp device is opened and vchan code gets in action (combined with other bad things). It can't be vchans alone because I just had three mpg123s open and they just played fine.