From owner-cvs-ports Sat Jan 10 20:21:24 1998 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id UAA09506 for cvs-ports-outgoing; Sat, 10 Jan 1998 20:21:24 -0800 (PST) (envelope-from owner-cvs-ports) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id UAA09312; Sat, 10 Jan 1998 20:20:15 -0800 (PST) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id UAA14173; Sat, 10 Jan 1998 20:15:48 -0800 (PST) Received: from UNKNOWN(), claiming to be "current1.whistle.com" via SMTP by alpo.whistle.com, id smtpd014168; Sat Jan 10 20:15:41 1998 Date: Sat, 10 Jan 1998 20:12:36 -0800 (PST) From: Julian Elischer To: Brian Somers cc: "Jordan K. Hubbard" , Peter Wemm , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-ports@FreeBSD.ORG Subject: Re: cvs commit: ports/www/squid12/patches patch-aj In-Reply-To: <199801102129.VAA19254@awfulhak.demon.co.uk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-ports@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk YES, put it in.. we have 27 diffs between our code on 2.2.x and 3.0 24 of them are: #if ( __FreeBSD__ >= 3 ) #include #endif this is a royal pain in the butt. julian On Sat, 10 Jan 1998, Brian Somers wrote: > > > #include , only on FreeBSD >= 3. Brought to you by the > > > lets-make-life-as-difficult-as-possible-by-screwing-up-the-headers team. > > > > Thank you for making this point - it's been driving me nuts too. Talk > > about adding a lot of pain for a minescule gain! This is just > > whitespace removal flying under a different banner. :-( > > I forget who, but someone talked about removing this if_var.h > necessity a while ago. I believe it was originally only intended as > a kernel-specific file. > > It's *way* un-standard, and a real pain in the ass for ports. If you > don't build a new net/* port on both 2.2 & -current, you're almost > definitely gonna get hit by this. > > Can't we just #include it at the end of net/if.h and be done with it ? > Please ? Or does anyone want to fix it properly ? > > > Jordan > > -- > Brian , , > > Don't _EVER_ lose your sense of humour.... > > >