Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Apr 2004 22:52:12 +0200
From:      "Cyrille Lefevre" <cyrille.lefevre@laposte.net>
To:        <arch@freebsd.org>
Cc:        "current @FreeBSD.org" <freebsd-current@freebsd.org>
Subject:   bin/41071: make NO to NO_ transition patch
Message-ID:  <00f401c4232b$8700d0c0$7890a8c0@dyndns.org>

next in thread | raw e-mail | index | archive | help
anyone interrested to validate and commit this PR ?

it provide a patch set to change all NOFOO variables to NO_FOO.

see thread "Standardized make options (or no doesn't always mean no)"
restart on 24 July 2002 in -arch for details and comments.

it depended on PR #41070 related to make enhancements and bug fixes
which has been partly commited some days ago (.warning keyword).

I'm using this patch for 2 years now w/o any problem except when upgrading
 perl from ports which should be fixed (no more NOPERL in /etc/make.conf).

 impacted files:
     	around 285 Makefiles
     	make.conf(5)
     	share/examples/etc/make.conf
     	share/mk/*.mk (well, only those w/ NOXXX vars :)

 new file:
     	share/mk/bsd.var.mk

 sample outputs:

 $ make -v /usr/share/mk/bsd.var.mk NOPERL=
 "/usr/share/mk/bsd.var.mk", line 146: warning: NO_PERL should be defined in
place of NOPERL -- using NO_PERL with the value of NOPERL and unsetting NOPERL.
 $ make -v /usr/share/mk/bsd.var.mk NOPERL= NO_PERL=
 "/usr/share/mk/bsd.var.mk", line 142: warning: both NO_PERL and NOPERL are
defined with the same value -- using NO_PERL and unsetting NOPERL.
 $ make -v /usr/share/mk/bsd.var.mk NOPERL=yes NO_PERL=no
 "/usr/share/mk/bsd.var.mk", line 139: warning: both NO_PERL and NOPERL are
defined with a different value -- using NO_PERL and unsetting NOPERL.
 $ make -v /usr/share/mk/bsd.var.mk NONO_PERL=
 "/usr/share/mk/bsd.var.mk", line 132: warning: NONO_PERL is defined -- 
unsetting NOPERL, NO_PERL and NONO_PERL.

 PS : for instance, NONOPERL isn't handled but could be easily added.

Cyrille Lefevre.
-- 
home: mailto:cyrille.lefevre@laposte.net



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?00f401c4232b$8700d0c0$7890a8c0>