Date: Wed, 7 Aug 2013 20:40:01 GMT From: "Simon J. Gerraty" <sjg@juniper.net> To: freebsd-bugs@FreeBSD.org Subject: Re: conf/181116: CURRENT build always uses bmake, even though WITHOUT_BMAKE is specified Message-ID: <201308072040.r77Ke16i063451@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR conf/181116; it has been noted by GNATS. From: "Simon J. Gerraty" <sjg@juniper.net> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: "FreeBSD-gnats-submit@FreeBSD.org" <FreeBSD-gnats-submit@FreeBSD.org>, "freebsd-bugs@FreeBSD.org" <freebsd-bugs@FreeBSD.org> Subject: Re: conf/181116: CURRENT build always uses bmake, even though WITHOUT_BMAKE is specified Date: Wed, 7 Aug 2013 13:32:17 -0700 On Wed, 7 Aug 2013 11:24:15 -0700, Garrett Cooper writes: >Ah, but src.conf controls WITH* (and the option is documented in the manage,= > along with all the others). You accidentally broke POLA :(. The real issue is that the option handling needs an overhaul. The processing of options should be extracted from bsd.own.mk to its own mk file which is always safe to include - bsd.own.mk is not. Then makefiles like src/Makefile could include it with the list of options it cares about - and bsd.own.mk could do the same. >> More importantly, is this a "test" or is there a percieved need to >> continue building with fmake? If so why? > >I gave up waiting for bmake and all the associated infrastructure to be back= >ported to stable/9 (and I know there's a snowball's chance in hades that it'= >ll be backported to stable/8), so I figured out how to make the test infrast= >ructure work independent of bmake. Why should that force you to use fmake for head? >> I was aiming to get rid of WITH[OUT]_BMAKE soon - in time for 10.0 > >This is a really bad idea. The fact that bmake causes conf/179111 without a m= >itigation strategy is reason alone to leave this knob in because I don't tru= >st all makefiles that exist outside of FreeBSD to work sanely without set -e= >. Heck, a lot of the Makefile snippets in FreeBSD don't behave sanely withou= >t set -e, as noted in the bug (and those are just a handful). You have the option of using .SHELL: to configure shell description that will set -e, though that will just perpetuate bad habbits. You said in 179111 that PR you have a patch?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201308072040.r77Ke16i063451>