Date: Sat, 7 Oct 2017 19:29:37 +0300 From: Guy Yur <guyyur@gmail.com> To: Warner Losh <imp@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r324360 - in head/sys/boot/efi: include libefi loader Message-ID: <CAC67Hz9oMO7q29U43ZJbjYTSfv-13yeNrBeuPscHP4oMFqWGLw@mail.gmail.com> In-Reply-To: <201710061221.v96CLko0046237@repo.freebsd.org> References: <201710061221.v96CLko0046237@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6 October 2017 at 15:21, Warner Losh <imp@freebsd.org> wrote: > Author: imp > Date: Fri Oct 6 12:21:46 2017 > New Revision: 324360 > URL: https://svnweb.freebsd.org/changeset/base/324360 > > Log: > Encapsulate ZFS preferences into efi_zfs_is_preferred > > Move the retrieval of the image information into loader's main instead > of doing it in efizfs.c > > Differential Revision: https://reviews.freebsd.org/D12564 > Submitted by: Eric McCorkle > > Modified: > head/sys/boot/efi/include/efizfs.h > head/sys/boot/efi/libefi/efizfs.c > head/sys/boot/efi/loader/main.c > > ... > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" Hi, When setting WITHOUT_ZFS in src.conf the build fails with: /usr/src/sys/boot/efi/loader/main.c:78:1: error: no previous prototype for function 'efi_zfs_is_preferred' [-Werror,-Wmissing-prototypes] efi_zfs_is_preferred(EFI_HANDLE *h) ^ 1 error generated. *** Error code 1 The prototype is under #ifdef EFI_ZFS_BOOT guard but the function is not. Thanks, Guy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAC67Hz9oMO7q29U43ZJbjYTSfv-13yeNrBeuPscHP4oMFqWGLw>