From owner-svn-src-all@freebsd.org Wed Sep 18 14:58:51 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B8BBBFF97A; Wed, 18 Sep 2019 14:58:51 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YNQz4YZpz4QTf; Wed, 18 Sep 2019 14:58:51 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 702791AF7; Wed, 18 Sep 2019 14:58:51 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f175.google.com with SMTP id g16so66895qto.9; Wed, 18 Sep 2019 07:58:51 -0700 (PDT) X-Gm-Message-State: APjAAAWPmmIAP5ERNW/Hb6pjWVeK0T/8UAvuwCv+7GgkwH5sEhufEhLT XZAfT1AHZxL+UMH2jjlQd/MmLQSP//G7Si1kff4= X-Google-Smtp-Source: APXvYqzamkyxn8O+Es7SzdKVmCuZIrjqK26ws4sXws03vZyVRQhQo0clFxjeasqgu9FjjIVDhJPvSsaNewf0eZzZkuc= X-Received: by 2002:a0c:9276:: with SMTP id 51mr3487907qvz.35.1568818730707; Wed, 18 Sep 2019 07:58:50 -0700 (PDT) MIME-Version: 1.0 References: <201909180158.x8I1wuZu011258@repo.freebsd.org> <0FBC9A62-AE3B-4F27-AABC-06FF45F415F1@gmail.com> <81382CF5-A928-48EF-93A9-BBBBA174F4BD@gmail.com> In-Reply-To: <81382CF5-A928-48EF-93A9-BBBBA174F4BD@gmail.com> From: Kyle Evans Date: Wed, 18 Sep 2019 09:58:38 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r352465 - head/share/mk To: Enji Cooper Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 14:58:51 -0000 On Wed, Sep 18, 2019 at 9:46 AM Enji Cooper wrote: > > > > On Sep 18, 2019, at 07:33, Enji Cooper wrote: > > > > > >>> On Sep 18, 2019, at 05:40, Kyle Evans wrote: > >>> > >>> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper w= rote: > >>> > >>> > >>>> On Sep 17, 2019, at 18:58, Kyle Evans wrote: > >>>> > >>>> Author: kevans > >>>> Date: Wed Sep 18 01:58:56 2019 > >>>> New Revision: 352465 > >>>> URL: https://svnweb.freebsd.org/changeset/base/352465 > >>>> > >>>> Log: > >>>> googletest: default-disable on all of MIPS for now > >>>> > >>>> Parts of the fusefs tests trigger a bug in current versions of llvm:= IR > >>>> representation of some routine for the MIPS targets is a function wi= th a > >>>> large number of arguments. This then leads the compiler on an hour+ = long > >>>> goose chase, which is OK if you build the current tree but less-so i= f you're > >>>> trying external toolchain or doing a universe build involving mips w= hen it > >>>> eventually gets switched over to LLVM. > >>>> > >>>> Better, accurate details can be found in LLVM PR43263. > >>> > >>> Uhhhhh... why not do this in tests/sys/... instead? > >> > >> Because there's still value in being able to easily enable these for > >> building/running the complete set of tests through standard build > >> infrastructure, but it's not worth adding a knob specifically for the > >> fusefs tests. I also prefer the communication of it being an > >> off-by-default option and easily deduced from src.conf(5) that this > >> part of the build is default-disabled on mips/mips. > > > > Let me rephrase things a bit: is googlemock broken for all of mips, or = is it just the tests? If the latter, the tests should be blacklisted for mi= ps with a justification. If the former, I agree your method of dealing with= the situation is ok, but more investigation needs to be done to see whethe= r or not the port (in general) is broken and mark it broken if need be. > > It looks like the latter case, based on the PR, and it=E2=80=99s a build = performance issue... Is this impacting CI pipelines? > It is the latter, and I do not want to *blacklist* them because as far as I can tell, the tests aren't necessarily broken. I want to workaround them for default by now. > > The problem with src.opts.mk=E2=80=99s per-architecture options, is tha= t it can be very heavy handed enabling/disabling features. I=E2=80=99m not = sure that everything in there warrants disabling at that level. > > My investigation suggests that the course of action was overly heavy hand= ed. While I=E2=80=99m not asking for a revert, it would be really nice if w= hole features weren=E2=80=99t disabled, unless there=E2=80=99s an issue wit= h the feature. > We do not have a lighter method for dealing with this that I can tell, because as I said above: I do not want to blacklist them or completely kill them off. I still want the option to build and test them, but as I aim to switch mips over to llvm I do not want to subject CI and the rest of the world to an extra 1.5+ hour build time for this during tinderbox runs. Given that it's mips, so already tier-high, and I'm one of few people that care about it (and I only care about it for the time being), I intend to leave it as-is since it's still a default in the rest of the world.