Date: Wed, 22 May 2019 11:40:42 -0400 From: Alexander Motin <mav@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310524 - in head/sys/cam: ctl scsi Message-ID: <8fdc1e42-b8aa-3af1-27b3-f78c3918e7ea@FreeBSD.org> In-Reply-To: <20190522152124.GA36423@FreeBSD.org> References: <201612241742.uBOHgYQp045291@repo.freebsd.org> <20190522152124.GA36423@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22.05.2019 11:21, Alexey Dokuchaev wrote: > On Sat, Dec 24, 2016 at 05:42:34PM +0000, Alexander Motin wrote: >> New Revision: 310524 >> URL: https://svnweb.freebsd.org/changeset/base/310524 >> >> Log: >> Improve length handling when writing sense data. >> >> - Allow maximal sense size limitation via Control Extension mode page. >> - When sense size limited, include descriptors atomically: whole or none. >> - Set new SDAT_OVFL bit if some descriptors don't fit the limit. >> - Report real written sense length instead of static maximal 252 bytes. >> >> Modified: head/sys/cam/scsi/scsi_all.c >> ... >> + } >> + if (len > sizeof(sense->cmd_spec_info)) { >> + data += len - sizeof(sense->cmd_spec_info); >> + len -= len - sizeof(sense->cmd_spec_info); > > PVS Studio complains here: error: V765 A compound assignment expression 'x > -= x - ...' is suspicious. Consider inspecting it for a possible error. > > This "len -= len - sizeof(...)" indeed looks weird, can you take a look? It may be weird, but not incorrect. Fixed though. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8fdc1e42-b8aa-3af1-27b3-f78c3918e7ea>