From owner-freebsd-geom@FreeBSD.ORG Sun Mar 8 22:35:55 2015 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 12568DA6 for ; Sun, 8 Mar 2015 22:35:55 +0000 (UTC) Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DEA8FFC for ; Sun, 8 Mar 2015 22:35:54 +0000 (UTC) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id 4495E37B547; Sun, 8 Mar 2015 17:35:53 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3l0cw84z3kz2NZ; Sun, 8 Mar 2015 17:35:52 -0500 (CDT) Date: Sun, 8 Mar 2015 17:35:52 -0500 From: "Matthew D. Fuller" To: Steven Hartland Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150308223552.GR1742@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <54FC4E99.4080202@multiplay.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54FC4E99.4080202@multiplay.co.uk> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.6 at thyme.infocus-llc.com X-Virus-Status: Clean Cc: freebsd-geom@freebsd.org X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Mar 2015 22:35:55 -0000 On Sun, Mar 08, 2015 at 01:28:57PM +0000 I heard the voice of Steven Hartland, and lo! it spake thus: > > I don't see where your checking if the underlying device supports DELETE? >From my understanding (which is hardly authoritative, to be sure, so I'm open to correction), I don't have to. GELI itself doesn't originate any BIO_DELETE's, so they're only coming from stuff on top of us. We just pass those through to what's underneath us and it does all the answering. If that doesn't support it, it would return an "I don't do that" response, which the filesystem (or whatever) on top of us handles[0] its way. So for _DELETE, as for _FLUSH and _GETATTR, GELI is just transparent. Am I mistaken? [0] Well, or doesn't, but that's it's problem, not ours. -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream.