Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 3 Nov 2010 08:44:13 +0100
From:      Hans Petter Selasky <hselasky@c2i.net>
To:        "Jung-uk Kim" <jkim@freebsd.org>
Cc:        freebsd-acpi@freebsd.org, Lin Ming <ming.m.lin@intel.com>, Andriy Gapon <avg@freebsd.org>, "Moore, Robert" <robert.moore@intel.com>
Subject:   Re: MacBookPro 5,1
Message-ID:  <201011030844.13412.hselasky@c2i.net>
In-Reply-To: <201011021529.05977.jkim@FreeBSD.org>
References:  <201010121209.06397.hselasky@c2i.net> <4CD02E6D.1070106@freebsd.org> <201011021529.05977.jkim@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 02 November 2010 20:29:01 Jung-uk Kim wrote:
> On Tuesday 02 November 2010 11:29 am, Andriy Gapon wrote:
> > on 29/10/2010 08:51 Andriy Gapon said the following:
> > > I guess that a general problem here is that it is incorrect to
> > > merely use memcpy/bcopy to create a copy of a resource if the
> > > resource has ACPI_RESOURCE_SOURCE field in it.
> > 
> > Hans,
> > 
> > could you please test the following patch?
> > 
> > diff --git a/sys/dev/acpica/acpi_pci_link.c
> > b/sys/dev/acpica/acpi_pci_link.c index dcf101d..e842635 100644
> > --- a/sys/dev/acpica/acpi_pci_link.c
> > +++ b/sys/dev/acpica/acpi_pci_link.c
> > @@ -767,6 +767,8 @@ acpi_pci_link_srs_from_crs
> > 
> >  				    link->l_irq;
> >  			
> >  			else
> >  			
> >  				resptr->Data.ExtendedIrq.Interrupts[0] = 0;
> > 
> > +			memset(&resptr->Data.ExtendedIrq.ResourceSource, 0,
> > +			    sizeof(ACPI_RESOURCE_SOURCE));
> > 
> >  			link++;
> >  			i++;
> >  			break;
> 
> Hmm...  Very interesting.  Can you please try this, too?
> 
> Thanks,
> 
> Jung-uk Kim

Hi,

I will try to get your patches tested in less than 10 hours from now.

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011030844.13412.hselasky>