Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 7 May 2013 06:59:58 +0200 (CEST)
From:      Jimmy Olgeni <olgeni@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r317548 - head/lang/erlang
Message-ID:  <alpine.BSF.2.00.1305070656470.5814@olgeni.olgeni>
In-Reply-To: <20130507014034.GB14600@FreeBSD.org>
References:  <201305062018.r46KIXbK048584@svn.freebsd.org> <20130507014034.GB14600@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Tue, 7 May 2013, Alexey Dokuchaev wrote:

> I don't quite understand this change.  Why move mkdir inside the 
loop?

Very dumb mistake on my part - I saw an "if" rather than a "for" :|

> The port itself could probably benefit from some cleaning and fixing of
> several style bugs.

Probably a good idea. Do you have a quick list of things I should look into?

--
jimmy



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1305070656470.5814>