From owner-cvs-all Thu Dec 13 11:28:14 2001 Delivered-To: cvs-all@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id E2FF937B41C for ; Thu, 13 Dec 2001 11:28:02 -0800 (PST) Received: (qmail 5525 invoked from network); 13 Dec 2001 19:28:02 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 13 Dec 2001 19:28:02 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20011213104749.A12719@locore.ca> Date: Thu, 13 Dec 2001 11:27:57 -0800 (PST) From: John Baldwin To: Jake Burkholder Subject: Re: cvs commit: src/sys/kern kern_ktr.c src/sys/sys proc.h Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 13-Dec-01 Jake Burkholder wrote: > Apparently, On Thu, Dec 13, 2001 at 02:33:20AM -0800, > John Baldwin said words to the effect of; > >> jhb 2001/12/13 02:33:20 PST >> >> Modified files: >> sys/kern kern_ktr.c >> sys/sys proc.h >> Log: >> Use a per-thread variable for keeping state when a thread is processing >> a KTR log entry. Any KTR requests made while working on an entry are >> ignored/discarded to prevent recursion. This is a better fix for the >> hack to futz with the CPU mask and call getnanotime() if KTR_LOCK or >> KTR_WITNESS was on. It also covers the actual formatting of the log entry >> including dumping it to the display which the earlier hacks did not. > > This wouldn't be necessary if ktr was still inline and didn't call other > functions. No. Remember the problem we had with nanotime() locking the clock lock and thus recursing if KTR_LOCK was on on x86? Even when KTR is inline, it still calls other functions and you can build up stack and recurse that way. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message