Date: Thu, 26 Sep 2002 16:34:47 -0700 From: Peter Wemm <peter@wemm.org> To: Greg 'groggy' Lehey <grog@FreeBSD.org> Cc: Ruslan Ermilov <ru@FreeBSD.org>, Juli Mallett <jmallett@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make parse.c Message-ID: <20020926233447.3E3102A7D6@canning.wemm.org> In-Reply-To: <20020926231005.GS10532@wantadilla.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Greg 'groggy' Lehey wrote: > On Thursday, 26 September 2002 at 11:50:38 +0300, Ruslan Ermilov wrote: > > On Wed, Sep 25, 2002 at 11:44:30PM -0700, Juli Mallett wrote: > >> jmallett 2002/09/25 23:44:30 PDT > >> > >> Modified files: > >> usr.bin/make parse.c > >> Log: > >> Remove a semicolon that appears to be a lie. > >> > >> Spotted by: SPARC64 make WARNS=3 > >> Sponsored by: Rachel Hestilow <rachel@jerkcity.com> > >> > >> Revision Changes Path > >> 1.43 +1 -1 src/usr.bin/make/parse.c > >> > > As an aside. Our make(1) suffers from the parsing bug in > > parse.c:ParseReadLine(). When it sees a colon (`:') it > > marks the line as being a "dependency" line, and when it > > later sees a semicolon (`;') it replaces it by a newline. > > The net effect is that the following fragment blows up: > > > > ... > > > > In OpenBSD, this has been fixed yet in 2001 by the new parsing code > > (parse.c,v 1.59 and related changes). > > What's stopping you from importing the fix? Well, given that it is fixed by 'the new parsing code', the clue should be that it is a pretty big change and not 'just a fix'. We've already learned the hard way that make(1) is hyper sensitive and anything more than low impact changes requires extensive testing which takes quite a bit of time. We are a volunteer project, and not everybody has the time to sit down and spend up to a week or so doing regression tests over the source trees, making sure that other platforms dont get broken, making sure that we can still cross build from various older releases, test 3rd party build structures etc etc. When somebody has the time and inclination to do it, it'll get done. For now we have a footnote that there is still an unresolved bug. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020926233447.3E3102A7D6>