From owner-freebsd-fs@FreeBSD.ORG  Sun Oct  9 22:37:23 2011
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8D9E1106566B;
	Sun,  9 Oct 2011 22:37:23 +0000 (UTC)
	(envelope-from yanegomi@gmail.com)
Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com
	[209.85.216.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 18FA48FC0A;
	Sun,  9 Oct 2011 22:37:22 +0000 (UTC)
Received: by qadz30 with SMTP id z30so4768289qad.13
	for <multiple recipients>; Sun, 09 Oct 2011 15:37:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	bh=9Bm7B/IAsFjy+OHzAjyFWQ/OR82Yhkb2CZY9WPy/8m0=;
	b=pk6LlpzNCEaizxdfJhoj4XjqZS9lsQfdsVlC2PlSrqbSxtQrIM6A4aX/IgGC4LoK3C
	CTEGC0Vg7DcuOTbZsAvqjnxfudSbBacG29ghVtq65M7q3punvpYVrTrum1UzFWKDxhrx
	iUuyunHwpOneA1sB30OkSRyQKkSEYz1GGCuRM=
MIME-Version: 1.0
Received: by 10.224.176.143 with SMTP id be15mr853040qab.33.1318199842346;
	Sun, 09 Oct 2011 15:37:22 -0700 (PDT)
Received: by 10.224.74.82 with HTTP; Sun, 9 Oct 2011 15:37:22 -0700 (PDT)
In-Reply-To: <CAGH67wS9G5Co+CjaVWrc-VX-mmp7CoEo0Cw7ysqpwkOMowRYCQ@mail.gmail.com>
References: <CAGH67wSYmcxJCbTMVL+qWzbLojiCiBmRF98yaNL4b3d3LbvbYw@mail.gmail.com>
	<201110012137.p91Lb6FI093841@chez.mckusick.com>
	<CAGH67wS9G5Co+CjaVWrc-VX-mmp7CoEo0Cw7ysqpwkOMowRYCQ@mail.gmail.com>
Date: Sun, 9 Oct 2011 15:37:22 -0700
Message-ID: <CAGH67wSfgQ+Dg0qQxkiKh4Uzt3E_J3rRL_=2PkbNvB=ii1f0LQ@mail.gmail.com>
From: Garrett Cooper <yanegomi@gmail.com>
To: Kirk McKusick <mckusick@mckusick.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: Attilio Rao <attilio@freebsd.org>, Xin LI <delphij@freebsd.org>,
	freebsd-fs@freebsd.org
Subject: Re: Need to force sync(2) before umounting UFS1 filesystems?
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Oct 2011 22:37:23 -0000

On Sun, Oct 9, 2011 at 3:22 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
> On Sat, Oct 1, 2011 at 2:37 PM, Kirk McKusick <mckusick@mckusick.com> wro=
te:
>>> Date: Sat, 1 Oct 2011 12:44:04 -0700
>>> Subject: Re: Need to force sync(2) before umounting UFS1 filesystems?
>>> From: Garrett Cooper <yanegomi@gmail.com>
>>> To: Attilio Rao <attilio@freebsd.org>
>>> Cc: Kostik Belousov <kostikbel@gmail.com>,
>>> =A0 =A0 =A0 =A0 Kirk McKusick <mckusick@mckusick.com>, freebsd-fs@freeb=
sd.org,
>>> =A0 =A0 =A0 =A0 Xin LI <delphij@freebsd.org>
>>>
>>> Ok. Now that I know this is the direction you guys want to go, I'll
>>> start testing the change.
>>
>> Thanks for throwing some testing at this. Please test my latest
>> proposed change (included below so you do not have to dig through
>> earlier email) as I believe that it has the least likelyhood of
>> problems and is what I am currently proposing to put in.
>
> I apologize for not getting this done sooner. It passes a smoke test
> with the following filesystems:
>
> nfs
> nullfs
> smbfs
> unionfs
> ufs
> zfs
>
> I'll be running more extensive stress tests soon, but it looks like a
> good step forward.

Forgot to note: my FreeNAS builds nanobsd no longer fail with the
attached patch after I remove my sync hacks :).
-Garrett