From owner-svn-src-all@freebsd.org Thu Jul 9 16:50:03 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C40CC36F96F; Thu, 9 Jul 2020 16:50:03 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B2hx66hdyz4Gns; Thu, 9 Jul 2020 16:50:02 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from pps.filterd (m0108160.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 069G8B18026423; Thu, 9 Jul 2020 09:16:43 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2170.outbound.protection.outlook.com [104.47.55.170]) by mx0b-00273201.pphosted.com with ESMTP id 325k2y9vsv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Jul 2020 09:16:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=baOOlYrxkCmzX0WpfwGRJvSH2jPj4+/p+Vv7Ptapx5VABSdzSLuKMhGoT4u7Q5+YnH7w+AM9Tca0vTKkVz0CQEqbExYX1nUtSQ+OCYhufnsCJkYBOzrXbUUvILvb6SLXviKg9YgsJOhlhK3pux/hXOZvo7fYUTdvUQhFJa9vKsZHqJuYnipNr+TNt1osNDJDUQLuwSdeD2x5Aoxa56n/6JQcTNO0NNOe8bnX55Y+JgdM/mz31C1aLRM9ON1+UjT5MEWO10K48GeOk8HWGGbW7gAbUj0FdIBiFrDJBy0kjgmqLGd0HrEZyW6wjWNjxWrpd2veA69Obf2xKC406TPsTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QpBQR+xQo+0+c6wEbVTPN6URV2k8MONYJ2yinV0j44M=; b=SAZvk8O0m2Syq8NT5Z2oAZ8II+CsaFuX6DhtPj4r/R0kAyWZNGk0E0x7CmJyK+PlFHyYRshxKgfCM8Q0UdXD4SO3RuYcWIFvFBSC50GlhfUtfdf1CcTM9dyicM3exJVgL1FKZX7ooSxxfkKVhjZ17C/C/f51tgcS5Iu4MRemktKXzhxG2QzgrMdw50REMf3OkhzbeEktXBT+Z6S4zoLocWe/UlUL3mhPExbLAoKzH2jaUuLJrkWEU9VfrPKQ8VvCyykig0zZNPp9GehbpzCHQNXhLNTuZbEaTzZJSN5qm8plssTpjW4H7DAWlAQWn/m62EILgixDMKjvqKKY8ZaMmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.239.13) smtp.rcpttodomain=freebsd.org smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none Received: from MWHPR21CA0055.namprd21.prod.outlook.com (2603:10b6:300:db::17) by CY4PR05MB3064.namprd05.prod.outlook.com (2603:10b6:903:fe::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.13; Thu, 9 Jul 2020 16:16:41 +0000 Received: from CO1NAM05FT028.eop-nam05.prod.protection.outlook.com (2603:10b6:300:db:cafe::2b) by MWHPR21CA0055.outlook.office365.com (2603:10b6:300:db::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.4 via Frontend Transport; Thu, 9 Jul 2020 16:16:41 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 66.129.239.13) smtp.mailfrom=juniper.net; FreeBSD.org; dkim=none (message not signed) header.d=none;FreeBSD.org; dmarc=fail action=oreject header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.13 as permitted sender) Received: from P-EXFEND-EQX-02.jnpr.net (66.129.239.13) by CO1NAM05FT028.mail.protection.outlook.com (10.152.96.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.3195.9 via Frontend Transport; Thu, 9 Jul 2020 16:16:40 +0000 Received: from P-EXBEND-EQX-02.jnpr.net (10.104.8.53) by P-EXFEND-EQX-02.jnpr.net (10.104.8.55) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 9 Jul 2020 09:16:39 -0700 Received: from P-EXBEND-EQX-01.jnpr.net (10.104.8.52) by P-EXBEND-EQX-02.jnpr.net (10.104.8.53) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 9 Jul 2020 09:16:39 -0700 Received: from p-mailhub01.juniper.net (10.104.20.6) by P-EXBEND-EQX-01.jnpr.net (10.104.8.52) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 9 Jul 2020 09:16:39 -0700 Received: from kaos.jnpr.net (kaos.jnpr.net [172.23.255.254]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id 069GGcCD010220; Thu, 9 Jul 2020 09:16:39 -0700 (envelope-from sjg@juniper.net) Received: by kaos.jnpr.net (Postfix, from userid 1377) id D5EDB6E5F5; Thu, 9 Jul 2020 09:16:38 -0700 (PDT) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id D44226E5F4; Thu, 9 Jul 2020 09:16:38 -0700 (PDT) To: Cy Schubert CC: , , , Subject: Re: svn commit: r363031 - in head: contrib/bmake contrib/bmake/lst.lib contrib/bmake/mk contrib/bmake/mk/sys contrib/bmake/unit-tests usr.bin/bmake In-Reply-To: <202007090402.06942mVr015813@slippy.cwsent.com> References: <202007082120.068LKCeN067904@repo.freebsd.org> <202007090328.0693SNo4028242@slippy.cwsent.com> <45359.1594266432@kaos.jnpr.net> <202007090402.06942mVr015813@slippy.cwsent.com> Comments: In-reply-to: Cy Schubert message dated "Wed, 08 Jul 2020 21:02:45 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 26.3 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22100.1594311398.1@kaos.jnpr.net> Date: Thu, 9 Jul 2020 09:16:38 -0700 Message-ID: <26265.1594311398@kaos.jnpr.net> X-EXCLAIMER-MD-CONFIG: e3cb0ff2-54e7-4646-8a04-0dae4ac7b136 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.13; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:P-EXFEND-EQX-02.jnpr.net; PTR:InfoDomainNonexistent; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(346002)(396003)(39860400002)(46966005)(82740400003)(8676002)(7696005)(55016002)(8936002)(107886003)(86362001)(83380400001)(4326008)(26005)(5660300002)(6266002)(6916009)(356005)(336012)(81166007)(82310400002)(7126003)(54906003)(316002)(47076004)(478600001)(2906002)(9686003)(70586007)(70206006)(186003); DIR:OUT; SFP:1102; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0c3f14d-db3e-41e0-3b23-08d824237681 X-MS-TrafficTypeDiagnostic: CY4PR05MB3064: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bUJIDcuy33ZcBn+KWdvobMt6Ydp7yzEa9qpya6vcaCVZoTK9rYrkEZkyGDBKAdWyTPwqF3oovb8B5ZifDZVi9mFCpHTUheW709X34T30Bb9CkPDTzIY0V+FPrL8PgG93lFuBJEP1RfHh2cTLnrM68mVSIvfkSVn9420OlUUUhG0NxOsDoaW3MkTtZH0a9akL81FBMdVDZqG0PbVfPVCPmJG9HgJuXIOJitZyKEvY3Zt23wdW1UkvzUYDHWi+fNPuN77JDTYZSKcZuIc80B1DOFAlvSHWuv4wVnL+C8ATvH0XPv/dgx8wJYgu8iXqVG3q3z2CIav409+lDo3IPNFggRDQH7hxHh9TDF9Y5vombtJhlFK3x4DvSQeAE5/UljLvkYtdw/vkyJ+7uNZpJFnxZw== X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2020 16:16:40.2621 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0c3f14d-db3e-41e0-3b23-08d824237681 X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.13]; Helo=[P-EXFEND-EQX-02.jnpr.net] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM05FT028.eop-nam05.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB3064 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-09_08:2020-07-09, 2020-07-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=5 bulkscore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=5 mlxlogscore=127 clxscore=1015 priorityscore=1501 phishscore=0 mlxscore=5 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007090116 X-Rspamd-Queue-Id: 4B2hx66hdyz4Gns X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.45 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.005]; R_DKIM_ALLOW(-0.20)[juniper.net:s=PPS1017,juniper.net:s=selector1]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:67.231.152.164]; NEURAL_HAM_LONG(-0.98)[-0.983]; MIME_GOOD(-0.10)[text/plain]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[juniper.net:+]; DMARC_POLICY_ALLOW(-0.50)[juniper.net,reject]; NEURAL_HAM_SHORT(-1.36)[-1.363]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22843, ipnet:67.231.152.0/24, country:US]; RCVD_COUNT_SEVEN(0.00)[11]; RCVD_IN_DNSWL_LOW(-0.10)[67.231.152.164:from] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2020 16:50:03 -0000 Cy Schubert wrote: > [External Email. Be cautious of content] > > > In message <45359.1594266432@kaos.jnpr.net>, "Simon J. Gerraty" writes: > > Cy Schubert wrote: > > > This broke ports. > > > > I've reverted the change. > > > > Let me know if you still see issue. > > As I said in my email, all I did was revert cond.c, and that fixed it. You > don't need to revert the whole patch. Just revert cond.c and let NetBSD > know. Ah I missed that bit - rats. I think I've a fix for cond.c, but unfortunately I'm so far unable to construct a unit-test that triggers the problem. Even with bsd.compiler.mk I was unable to get it to fail in debugger, so added an abort and looked at the core file. The problem is in something like: .if 1 || ${something-complicated} > 0 the ${something-complicated} isn't resolved because we do not need to evaluate anything after '1', but the comparator check is still applied. Fix should be simple, but in unit-tests the above does not trigger the problem ;-)