Date: Mon, 1 Aug 2011 00:33:11 +0100 From: "Steven Hartland" <killing@multiplay.co.uk> To: "Martin Matuska" <mm@FreeBSD.org>, "David P Discher" <dpd@bitgravity.com> Cc: freebsd-fs@FreeBSD.org, Andriy Gapon <avg@freebsd.org> Subject: Re: zfs process hang on pool access Message-ID: <0E851F439C384186A1D44A347C19A7D7@multiplay.co.uk> References: <A14F1C768A41483C876AD77502A864D6@multiplay.co.uk> <0D449EC916264947AB31AA17F870EA7A@multiplay.co.uk> <4E3013DF.10803@FreeBSD.org> <3D6CEB50BEDD4ACE96FD35C4D085618A@multiplay.co.uk> <4E301C55.7090105@FreeBSD.org> <5C84E7C8452E489C8CA738294F5EBB78@multiplay.co.uk> <4E301F10.6060708@FreeBSD.org> <63705B5AEEAD4BB88ADB9EF770AB6C76@multiplay.co.uk> <4E302204.2030009@FreeBSD.org> <6703F0BB-D4FC-4417-B519-CAFC62E5BC39@bitgravity.com> <04C305AE5F184C6AAC2A67CE23184013@multiplay.co.uk> <3D893A9B-2CD9-40EB-B4A2-5DBCBB72C62E@bitgravity.com> <4E35D2E5.4020108@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----- Original Message -----
From: "Martin Matuska" <mm@FreeBSD.org>
>I walked through all occurences of ddi_get_lbolt() in the ZFS code and
> this is the only place where it is incorrectly initialized.
> This is how it should look like.
>
> ===================================================================
> --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c (revision 224527)
> +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c (working copy)
> @@ -488,7 +488,7 @@
> txg_delay(dsl_pool_t *dp, uint64_t txg, int ticks)
> {
> tx_state_t *tx = &dp->dp_tx;
> - int timeout = ddi_get_lbolt() + ticks;
> + clock_t timeout = ddi_get_lbolt() + ticks;
So you recon that one line will fix the 100+ days overflow David's talking about?
Regards
Steve
================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it.
In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postmaster@multiplay.co.uk.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0E851F439C384186A1D44A347C19A7D7>