Date: Thu, 6 Jul 2017 10:32:00 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: John Baldwin <jhb@FreeBSD.org> Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r320701 - in head: bin sbin usr.bin usr.sbin Message-ID: <EE30CB94-0C60-40BB-9E62-B643313150C8@gmail.com> In-Reply-To: <4ac448c4-af76-de43-5dbc-370492962d59@FreeBSD.org> References: <201707060415.v664FU9n085204@repo.freebsd.org> <4ac448c4-af76-de43-5dbc-370492962d59@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jul 6, 2017, at 03:31, John Baldwin <jhb@FreeBSD.org> wrote: >=20 >> On 7/6/17 12:15 AM, Ngie Cooper wrote: >> Author: ngie >> Date: Thu Jul 6 04:15:30 2017 >> New Revision: 320701 >> URL: https://svnweb.freebsd.org/changeset/base/320701 >>=20 >> Log: >> Remove SUBDIR ordering/uniquifying in *bin/Makefile >>=20 >> After the addition of SUBDIR.yes, uniquifying/ordering the SUBDIRs doesn= 't >> make a whole lot of sense, and it's in effect a half measure. >>=20 >> Ordering SUBDIR (after adding SUBDIR.yes to it) in bsd.subdir.mk is a >> separate change that warrants more discussion/testing, because while >> the SUBDIR_PARALLEL work largely fixed dependency ordering for SUBDIRs, >> there might be downstream FreeBSD consumers that rely on the SUBDIR >> ordering. >=20 > FWIW, I (as a human) am used to sorted build output when watching the > output of 'buildworld' to gauge how far it has completed. This was a > feature that SVN broke (CVS would walk directories in sorted order so > you could do the same sort of guessing for 'cvs up' but you can't for > 'svn up'). It's not a hard dependency, per se, but it would be nice to > preserve this feature if possible. I had noticed that it had become > less correct "recently". I have another change I'm going to propose soon which sorts SUBDIR outpu= t (as a whole) again, as an opt-in feature in bsd.subdir.mk. Cheers, -Ngie=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EE30CB94-0C60-40BB-9E62-B643313150C8>