Date: Mon, 10 Feb 2014 09:47:17 +0000 From: David Chisnall <theraven@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, Steve Wills <swills@FreeBSD.org>, svn-ports-all@FreeBSD.org, John Marino <marino@FreeBSD.org>, ports-committers@FreeBSD.org Subject: Re: svn commit: r343559 - head/net-p2p/litecoin Message-ID: <E8F403F4-EA83-4F71-82E6-9BA27D8D217C@FreeBSD.org> In-Reply-To: <20140210075232.GU80056@ithaqua.etoilebsd.net> References: <201402092329.s19NTHiq089517@svn.freebsd.org> <20140210011718.GA79272@mouf.net> <20140210075232.GU80056@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10 Feb 2014, at 07:52, Baptiste Daroussin <bapt@FreeBSD.org> wrote: > I do not think that requires an approval, as for FreeBSD this change = is no-op, > It is also no intrusive and just "fixes" building of that port for = Dragonfly. Relying on OPSYS and OSVERSION is pretty horrible and doesn't scale. = Already we have problems with convoluted OSVERSION expressions that are = hard to understand and really mean 'fix for PR12345 has been merged to = the relevant branch'. It would be far better to centralise these into a = single file for each platform, listing features / bugfixes / needed = work-arounds and start removing explicit OSVERSION checks from any other = Makefiles. If supporting Dragonfly is one of our objectives, then I'd = strongly encourage the people who are working on it to engage in this = kind of cleanup, rather than piling more hacks into the tree. David
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E8F403F4-EA83-4F71-82E6-9BA27D8D217C>