Date: Thu, 15 Nov 2018 21:47:35 +0100 From: Vincenzo Maffione <v.maffione@gmail.com> To: rgrimes@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r340461 - in stable/12/sys/dev: netmap virtio/network Message-ID: <CA%2B_eA9hSEW89h8foOTjfeTeF5f9B-mLJTbcukYAN6y2A26fY3Q@mail.gmail.com> In-Reply-To: <201811152046.wAFKkiNH042882@pdx.rh.CN85.dnsmgr.net> References: <201811151851.wAFIpbA4025094@repo.freebsd.org> <201811152046.wAFKkiNH042882@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
No worries Cheers, Vincenzo On Thu, Nov 15, 2018, 9:46 PM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net wrote: > > Author: vmaffione > > Date: Thu Nov 15 18:51:37 2018 > > New Revision: 340461 > > URL: https://svnweb.freebsd.org/changeset/base/340461 > > > > Log: > > MFC :r340436 > > > > vtnet: fix netmap support > > > > netmap(4) support for vtnet(4) was incomplete and had multiple bugs. > > This commit fixes those bugs to bring netmap on vtnet in a functional > state. > > > > Changelist: > > - handle errors returned by virtqueue_enqueue() properly (they were > > previously ignored) > > - make sure netmap XOR rest of the kernel access each virtqueue. > > - compute the number of netmap slots for TX and RX separately, > according to > > whether indirect descriptors are used or not for a given virtqueue. > > - make sure sglist are freed according to their type (mbufs or netmap > > buffers) > > - add support for mulitiqueue and netmap host (aka sw) rings. > > - intercept VQ interrupts directly instead of intercepting them in > txq_eof > > and rxq_eof. This simplifies the code and makes it easier to make > sure > > taskqueues are not running for a VQ while it is in netmap mode. > > - implement vntet_netmap_config() to cope with changes in the number > of queues. > > > > Sponsored by: Sunny Valley Networks > > Differential Revision: https://reviews.freebsd.org/D17916 > > Approved by: re (gjb) > > Thank you for getting this merged early, intime for RC1. > > > -- > Rod Grimes > rgrimes@freebsd.org >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2B_eA9hSEW89h8foOTjfeTeF5f9B-mLJTbcukYAN6y2A26fY3Q>