Date: Sun, 24 Jul 2016 03:15:08 -0700 From: Gleb Smirnoff <glebius@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303263 - in head/sys: compat/svr4 net Message-ID: <20160724101508.GJ1076@FreeBSD.org> In-Reply-To: <201607241010.u6OAA9IJ012434@repo.freebsd.org> References: <201607241010.u6OAA9IJ012434@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 24, 2016 at 10:10:09AM +0000, Gleb Smirnoff wrote: T> Author: glebius T> Date: Sun Jul 24 10:10:09 2016 T> New Revision: 303263 T> URL: https://svnweb.freebsd.org/changeset/base/303263 T> T> Log: T> Partially revert r257696/r257713, which have an issue with writing to user T> controlled address. Restore the old code that emulated OSIOCGIFCONF in if.c. T> T> Noticed by: C Turt I believe no one on the planet uses compat_svr4, but better fix it for 11.0-RELEASE, since too late to remove it. Note that SVR4_SIOCGIFCONF actually won't work for FreeBSD 10.x, if you load in compat_svr4.ko, since it depends on COMPAT_43 functionality compiled in kernel, which isn't case for i386 GENERIC. Of course the change wasn't tested, since I don't know how to produce or where to take an SVR4 binary that does something useful with SVR4_SIOCGIFCONF. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160724101508.GJ1076>