Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Oct 2014 00:47:16 +0200
From:      =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To:        Xin LI <delphij@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r273552 - head/sys/kern
Message-ID:  <86egtyz9mz.fsf@nine.des.no>
In-Reply-To: <201410231823.s9NINpXD082633@svn.freebsd.org> (Xin LI's message of "Thu, 23 Oct 2014 18:23:51 %2B0000 (UTC)")
References:  <201410231823.s9NINpXD082633@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Xin LI <delphij@FreeBSD.org> writes:
> Log:
>   Test if 'env' is NULL before doing memset() and strlen(),
>   the caller may pass NULL to freeenv().

If this is in response to a panic in early boot, the real bug is
elsewhere (see r273564).  Adding a NULL check here only hides it.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86egtyz9mz.fsf>