Date: Tue, 5 Feb 2013 18:40:04 GMT From: Giorgos Keramidas <keramida@FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: conf/175751: FreeBSD 10.0-CURRENT: build failure with "device runfw" Message-ID: <201302051840.r15Ie4e4013573@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR conf/175751; it has been noted by GNATS.
From: Giorgos Keramidas <keramida@FreeBSD.org>
To: Issei <i10a@herbmint.jp>
Cc: bug-followup@freebsd.org, Andrew Thompson <thompsa@freebsd.org>
Subject: Re: conf/175751: FreeBSD 10.0-CURRENT: build failure with "device
runfw"
Date: Tue, 5 Feb 2013 19:38:17 +0100
On 2013-02-01 07:23, Issei <i10a@herbmint.jp> wrote:
> >Number: 175751
> >Category: conf
> >Synopsis: FreeBSD 10.0-CURRENT: build failure with "device runfw"
> On FreeBSD 10.0-CURRENT/amd64 or /arm, moist recent sources, adding
> "device runfw" to kernel configuration file results in build error.
> cc -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-thumb-interw ork -ffreestanding -c runfw.c
> uudecode -o runfw /usr/src/sys/contrib/dev/run/rt2870.fw.uu
> ld -b binary --no-warn-mismatch -d -warn-common -r -o runfw.fwo
> ld: no input files
> *** [runfw.fwo] Error code 1
Andrew (thompsa) may want to chime in and check this change for runfw
too, so I've Cc:ed him in this thread too.
This error is present for amd64 too. I just tried rebuilding a kernel
with this configuration file, and I can reproduce this error myself too:
kobe:~$ cat -nv /usr/src/sys/amd64/conf/RUNFW
1 #
2 # RUNFW -- test kernel for device runfw
3 #
4 include GENERIC
5 ident RUNFW
6
7 device firmware
8 device runfw
kobe:~$
And this is indeed the fix, because it breaks the circular dependency of
'runfw -> runfw' in sys/conf/files. Thanks!
> Index: sys/conf/files
> ===================================================================
> --- sys/conf/files (revision 246145)
> +++ sys/conf/files (working copy)
> @@ -2208,19 +2208,19 @@
> dev/usb/wlan/if_rum.c optional rum
> dev/usb/wlan/if_run.c optional run
> runfw.c optional runfw \
> - compile-with "${AWK} -f $S/tools/fw_stub.awk runfw:runfw -mrunfw -c${.TARGET}" \
> + compile-with "${AWK} -f $S/tools/fw_stub.awk runfw.fw:runfw -mrunfw -c${.TARGET}" \
> no-implicit-rule before-depend local \
> clean "runfw.c"
> runfw.fwo optional runfw \
> - dependency "runfw" \
> + dependency "runfw.fw" \
> compile-with "${NORMAL_FWO}" \
> no-implicit-rule \
> clean "runfw.fwo"
> -runfw optional runfw \
> +runfw.fw optional runfw \
> dependency "$S/contrib/dev/run/rt2870.fw.uu" \
> compile-with "${NORMAL_FW}" \
> no-obj no-implicit-rule \
> - clean "runfw"
> + clean "runfw.fw"
> dev/usb/wlan/if_uath.c optional uath
> dev/usb/wlan/if_upgt.c optional upgt
> dev/usb/wlan/if_ural.c optional ural
> Index: sys/modules/runfw/Makefile
> ===================================================================
> --- sys/modules/runfw/Makefile (revision 246145)
> +++ sys/modules/runfw/Makefile (working copy)
> @@ -1,11 +1,11 @@
> # $FreeBSD$
>
> KMOD= runfw
> -FIRMWS= runfw:runfw:1
> +FIRMWS= runfw.fw:runfw:1
>
> -CLEANFILES= runfw
> +CLEANFILES= runfw.fw
>
> -runfw: ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu
> +runfw.fw: ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu
> uudecode -p ${.CURDIR}/../../contrib/dev/run/rt2870.fw.uu > ${.TARGET}
>
> .include <bsd.kmod.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302051840.r15Ie4e4013573>