From owner-freebsd-bugs@FreeBSD.ORG  Thu Feb  7 22:00:05 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 36D3E16A41B
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  7 Feb 2008 22:00:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 26BF813C46B
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  7 Feb 2008 22:00:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m17M0472010371
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 7 Feb 2008 22:00:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m17M04sj010370;
	Thu, 7 Feb 2008 22:00:04 GMT (envelope-from gnats)
Date: Thu, 7 Feb 2008 22:00:04 GMT
Message-Id: <200802072200.m17M04sj010370@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Jaakko Heinonen <jh@saunalahti.fi>
Cc: 
Subject: Re: kern/120319: fsck on read-only root fs upgrades it to read-write
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Jaakko Heinonen <jh@saunalahti.fi>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2008 22:00:05 -0000

The following reply was made to PR kern/120319; it has been noted by GNATS.

From: Jaakko Heinonen <jh@saunalahti.fi>
To: Yar Tikhiy <yar@comp.chem.msu.su>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/120319: fsck on read-only root fs upgrades it to
	read-write
Date: Thu, 7 Feb 2008 23:53:23 +0200

 On 2008-02-07, Yar Tikhiy wrote:
 > > This happens because the kernel doesn't set the "ro" mount option
 > > initially for mounts in vfs_mountroot_try() (vfs_mount.c). ffs_mount()
 > > remounts a file system as read-write if the "ro" option is missing.
 > 
 > You've hit the nail on the head!  Now the question is: Which of the
 > two functions should be fixed after all?  Some parts of the system
 > seem to rely solely on MNT_RDONLY to get a read-only mount, so it
 > might be wrong for ffs_mount() to look for the "ro" option even if
 > MNT_RDONLY is set in the mount flags.  Any ideas?
 
 Seems that msdosfs, ext2fs, nfs and zfs also rely on "ro" on remount. So
 changing ffs_mount() means changes for other file systems too to keep
 their behavior identical. For me the vfs_mountroot_try() approach seems
 logical because that unifies behavior of mount(8) and
 vfs_mountroot_try().
 
 -- 
 Jaakko