From owner-freebsd-ports  Wed Jun 12 14: 0:27 2002
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 2F90037B405
	for <freebsd-ports@hub.freebsd.org>; Wed, 12 Jun 2002 14:00:05 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g5CL05X14359;
	Wed, 12 Jun 2002 14:00:05 -0700 (PDT)
	(envelope-from gnats)
Received: from ftp.translate.ru (ftp.translate.ru [195.131.4.140])
	by hub.freebsd.org (Postfix) with ESMTP id B97A137B407
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 12 Jun 2002 13:55:39 -0700 (PDT)
Received: (from lev@localhost)
	by ftp.translate.ru (8.11.6/8.11.2) id g5CKwPt30548;
	Thu, 13 Jun 2002 00:58:25 +0400 (MSD)
	(envelope-from lev)
Message-Id: <200206122058.g5CKwPt30548@ftp.translate.ru>
Date: Thu, 13 Jun 2002 00:58:25 +0400 (MSD)
From: "Lev A. Serebryakov" <lev@serebryakov.spb.ru>
Reply-To: "Lev A. Serebryakov" <lev@serebryakov.spb.ru>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Subject: ports/39203: Unclear BREAK message in port net/samba
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org


>Number:         39203
>Category:       ports
>Synopsis:       Unclear BREAK message in port net/samba
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 12 14:00:05 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Lev A. Serebryakov <lev@serebryakov.spb.ru>
>Release:        FreeBSD 4.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD freebsd.sereb.net 4.4-STABLE FreeBSD 4.4-STABLE #1: Sat Dec 8 13:48:40 MSK 2001 root@freebsd.sereb.net:/usr/obj/usr/src/sys/LEVMAIL i386
Ports collection: 13 Jun 2002


>Description:
	
   net/samba port support ACLs only under FreeBSD 5.0-CURRENT.
   But new dialog(1)-based configuration script allows to select ACLs
   feature on any system. If user selects ACLs on 4.x or other old
   system, port systyem (via make(1)) prints this message:

===>  samba-2.2.4_1 is marked as broken: Requires a recent FreeBSD 5.0-CURRENT.

   And after that `make install' would not work at all.

   User, who doesn't know about how ACLs support is implemented, could not
   understand, WHY is samba broken on 4.x.

   I think, message should be replaced with somethin like this:

   ACL support requires a recent FreeBSD 5.0-CURRENT

   or, even better, `scripts/configure.samba' should detect old system
   and add `ACL support' checkbox only on new ones.

   I thinke, both of this changes could be done.

>How-To-Repeat:

  
   Try to select ACL support on 4.x system
	

>Fix:

   I don't prepare any pathses, but fix of message is trivial and
   fix for script could be like this:

OSVERSION=`make -V OSVERSION`
if [ ${OSVERSION} -le 500018 ]; then
	ACL_PARAM="acl		\"With ACL support\" OFF"
else
	ACL_PARAM=""
fi
   
  And after this add ${ACL_PARAM} to dialog(1) command line.
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message