Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Apr 1995 23:34:18 -0700 (PDT)
From:      "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
To:        jkh@freefall.cdrom.com (Jordan K. Hubbard)
Cc:        jkh@freebsd.org, CVS-commiters@time.cdrom.com, cvs-ports@time.cdrom.com, vode@snakemail.hut.fi
Subject:   Re: cvs commit: ports/net/sup/patches patch-ae
Message-ID:  <199504060634.XAA02561@gndrsh.aac.dev.com>
In-Reply-To: <11471.797149153@freefall.cdrom.com> from "Jordan K. Hubbard" at Apr 5, 95 11:19:13 pm

next in thread | previous in thread | raw e-mail | index | archive | help
> 
> > No man page updates for it :-(.
> > No way to turn it off :-(.
> > 
> > And admitted hackery in the code:
> > +       char rfname[1024];      /* Kludge alert.. */
> 
> 
> 1. Sorry, I thought he'd changed the manpage.  I'll document it if he
>    doesn't beat me to it.

That means you didn't even look at the patch close enough
to know what files where patched.  How much of a review could that have
really been :-(

> 2. You turn it off by not creating a file with the special name.. :-)

And double the number of stat calls made during the already slow sup :-(.

> 3. You would prefer that he simply not admit to the hackery? ;-)

No, I prefer that we not import hackery into our code base.  I am not
the only one who is unhappy about these changes.



-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                   Custom computers for FreeBSD



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199504060634.XAA02561>