From owner-freebsd-commit Wed Apr 5 23:34:41 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA11828 for commit-outgoing; Wed, 5 Apr 1995 23:34:41 -0700 Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id XAA11815 for cvs-ports-outgoing; Wed, 5 Apr 1995 23:34:36 -0700 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id XAA11808 ; Wed, 5 Apr 1995 23:34:33 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id XAA10233; Wed, 5 Apr 1995 23:34:31 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.8/8.6.6) id XAA02561; Wed, 5 Apr 1995 23:34:18 -0700 From: "Rodney W. Grimes" Message-Id: <199504060634.XAA02561@gndrsh.aac.dev.com> Subject: Re: cvs commit: ports/net/sup/patches patch-ae To: jkh@freefall.cdrom.com (Jordan K. Hubbard) Date: Wed, 5 Apr 1995 23:34:18 -0700 (PDT) Cc: jkh@freebsd.org, CVS-commiters@time.cdrom.com, cvs-ports@time.cdrom.com, vode@snakemail.hut.fi In-Reply-To: <11471.797149153@freefall.cdrom.com> from "Jordan K. Hubbard" at Apr 5, 95 11:19:13 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Content-Length: 916 Sender: commit-owner@freebsd.org Precedence: bulk > > > No man page updates for it :-(. > > No way to turn it off :-(. > > > > And admitted hackery in the code: > > + char rfname[1024]; /* Kludge alert.. */ > > > 1. Sorry, I thought he'd changed the manpage. I'll document it if he > doesn't beat me to it. That means you didn't even look at the patch close enough to know what files where patched. How much of a review could that have really been :-( > 2. You turn it off by not creating a file with the special name.. :-) And double the number of stat calls made during the already slow sup :-(. > 3. You would prefer that he simply not admit to the hackery? ;-) No, I prefer that we not import hackery into our code base. I am not the only one who is unhappy about these changes. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD